Skip to content

chore: remove unused counting proxy#2967

Merged
miparnisari merged 1 commit intomainfrom
remove-counting-proxy
Mar 11, 2026
Merged

chore: remove unused counting proxy#2967
miparnisari merged 1 commit intomainfrom
remove-counting-proxy

Conversation

@miparnisari
Copy link
Contributor

@miparnisari miparnisari commented Mar 11, 2026

Description

The proxy stopped emmitting metrics after we removed the middleware 😅 : fd6ca35#diff-6ae9faef9b462443abb234855106fee0b829623efba66a3c0b3217eb5ad9087c

And anyway we can get data from spicedb_datastore_query_latency_count:

image

@miparnisari miparnisari requested a review from barakmich March 11, 2026 00:16
@miparnisari miparnisari requested a review from a team as a code owner March 11, 2026 00:16
@github-actions github-actions bot added area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Mar 11, 2026
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.84%. Comparing base (9d4d4b7) to head (bc8203a).
⚠️ Report is 1 commits behind head on main.

❌ Your project status has failed because the head coverage (74.84%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2967       +/-   ##
===========================================
+ Coverage   48.86%   74.84%   +25.98%     
===========================================
  Files         431      497       +66     
  Lines       54679    60621     +5942     
===========================================
+ Hits        26714    45365    +18651     
+ Misses      25251    12099    -13152     
- Partials     2714     3157      +443     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@miparnisari miparnisari force-pushed the remove-counting-proxy branch from 94de4ba to 75aa0e1 Compare March 11, 2026 23:09
@miparnisari miparnisari enabled auto-merge (squash) March 11, 2026 23:10
@miparnisari miparnisari force-pushed the remove-counting-proxy branch from 75aa0e1 to bc8203a Compare March 11, 2026 23:23
@miparnisari miparnisari merged commit b554261 into main Mar 11, 2026
43 of 44 checks passed
@miparnisari miparnisari deleted the remove-counting-proxy branch March 11, 2026 23:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) Skip-Changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants