Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (74.84%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2967 +/- ##
===========================================
+ Coverage 48.86% 74.84% +25.98%
===========================================
Files 431 497 +66
Lines 54679 60621 +5942
===========================================
+ Hits 26714 45365 +18651
+ Misses 25251 12099 -13152
- Partials 2714 3157 +443 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
94de4ba to
75aa0e1
Compare
barakmich
approved these changes
Mar 11, 2026
75aa0e1 to
bc8203a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The proxy stopped emmitting metrics after we removed the middleware 😅 : fd6ca35#diff-6ae9faef9b462443abb234855106fee0b829623efba66a3c0b3217eb5ad9087c
And anyway we can get data from
spicedb_datastore_query_latency_count: