Skip to content

chore: bring in spicedb and update compilation#635

Draft
tstirrat15 wants to merge 3 commits intomainfrom
tstirrat/bring-in-new-schemadsl
Draft

chore: bring in spicedb and update compilation#635
tstirrat15 wants to merge 3 commits intomainfrom
tstirrat/bring-in-new-schemadsl

Conversation

@tstirrat15
Copy link
Contributor

Description

This is a part of getting the composable schema package unified in our tooling, which will (eventually) provide a better DX.

Changes

TODO

Testing

Review.

@tstirrat15 tstirrat15 force-pushed the tstirrat/bring-in-new-schemadsl branch from 610e2cc to 1fb916b Compare March 11, 2026 19:42
@tstirrat15 tstirrat15 marked this pull request as draft March 11, 2026 19:42
@tstirrat15
Copy link
Contributor Author

tstirrat15 commented Mar 11, 2026

Current TODOs and notes:

  • Merge chore: make development system filesystem-aware spicedb#2965 and then go get that SHA to make this reference that code.
  • Validation tests are failing. My best guess is that one if not all of the failures have to do with the DirFS() that's being handed to the DevContext in the validate command - it needs to match the dir of the validation file, not the invocation dir.
  • Need to check whether validations against just schemas are pointing their warnings at the correct lines (this should be captured in a test, but should also be validated)
  • It needs a test of a schema that imports another schema and there's a validation warning/error in that other schema to see whether it points at the correct file and line within that file
  • This should be hand-tested against a few things as well - validation files in the example repo, some composable schema stuff, etc.

@miparnisari miparnisari force-pushed the tstirrat/bring-in-new-schemadsl branch from 1fb916b to 5327e9a Compare March 12, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants