Check MacOS arch so the arm64 package would not be used for x86-64#2819
Closed
siphonelee wants to merge 1 commit intoava-labs:mainfrom
Closed
Check MacOS arch so the arm64 package would not be used for x86-64#2819siphonelee wants to merge 1 commit intoava-labs:mainfrom
siphonelee wants to merge 1 commit intoava-labs:mainfrom
Conversation
…; 2. add/fix test cases accordingly
felipemadero
approved these changes
Dec 23, 2025
Collaborator
|
Thank you for the contribution and the detailed bug report! We've included your fix in #2994 with minor style adjustments to the error message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My MacOS is x86-64, and when I tried to run "avalanche network start", I got an error like this:
Then I found out that avalanche didn't provide pre-built package for MacOS x86-64 (only for MacOS arm64), but in source code it checked OS type only without checking for arch type.
This is the fix and accordingly added/fixed test cases.