fix: handle missing error check if calling list regions API fail#2874
Closed
rochana-atapattu wants to merge 1 commit intoava-labs:mainfrom
Closed
fix: handle missing error check if calling list regions API fail#2874rochana-atapattu wants to merge 1 commit intoava-labs:mainfrom
rochana-atapattu wants to merge 1 commit intoava-labs:mainfrom
Conversation
rochana-atapattu
requested review from
Tonix517,
artemanosov,
cwend-ava,
jasonatran,
learyce,
meaghanfitzgerald and
sukantoraymond
rochana-atapattu
changed the title
felipemadero
approved these changes
Dec 23, 2025
Collaborator
|
Thank you for the contribution! We've included your fix in #2994. We couldn't merge your PR directly due to branch protection requiring GPG-signed commits, so we applied the changes on our end. Great catch on the missing error handling! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
handling a missed error check
How this works
propagating the error and handle it
How this was tested
running the command to different inputs, can't validate it to completion because of #2873