Conversation
…ereum#29514) Cherry-pick of `69f815f6f5791e0e48160bdad284773d0ffb1ba9`.
core/types/block.go
Outdated
There was a problem hiding this comment.
note this change is compulsory since there are more fields present in the struct than these 3.
qdm12
force-pushed
the
qdm12/core/types/body-hooks-rlp
branch
from
edebe13 to
e7193b7
Compare
qdm12
force-pushed
the
qdm12/core/types/body-hooks-rlp
branch
from
e7193b7 to
7f6afca
Compare
qdm12
changed the base branch from
darioush/libevm-phase-2.5
to
qdm12/core/types/header-copy-hooks
|
|
||
| // EncodeRLP implements the [rlp.Encoder] interface. | ||
| func (b *Body) EncodeRLP(w io.Writer) error { | ||
| return b.hooks().EncodeRLP(b, w) |
There was a problem hiding this comment.
Completely overriding RLP {en,de}coding is a blunt tool that we used for Header only because of the complexity of the modifications to that type (with the view to hopefully changing it in the future). I think it's possible to achieve this for Body without a hook, using just the rules of RLP optional, but I need to tinker a bit to confirm.
My greatest concern with a complete override is that the user still has to implement a lot of the upstream functionality, reducing the benefit of libevm.
There was a problem hiding this comment.
Progress on #109 suggests that this should be possible, with a hook that only needs to write fields to an rlp.EncoderBuffer. I'll confirm tomorrow.
qdm12
changed the title
Body RLP codec hooksBody RLP codec hooks
qdm12
added
the
Status: 🔴 DO NOT MERGE
qdm12
force-pushed
the
qdm12/core/types/header-copy-hooks
branch
2 times, most recently
from
18383c7 to
def07f8
Compare
qdm12
changed the title
Body RLP codec hooksBody RLP codec hooks
|
Closed in favor of #109 |
3 participants
Why this should be merged
How this works
How this was tested
BlockandBodyfrom libevm (6) coreth#760