fix(libevm/legacy): PrecompiledStatefulContract gas and remaining gas handling#114
Merged
fix(libevm/legacy): PrecompiledStatefulContract gas and remaining gas handling#114
PrecompiledStatefulContract gas and remaining gas handling#114Conversation
…PrecompiledStatefulContract`
qdm12
force-pushed
the
qdm12/libevm/legacy/precompile-gas
branch
from
67cc308 to
c130fa0
Compare
qdm12
commented
Feb 4, 2025
qdm12
force-pushed
the
qdm12/libevm/legacy/precompile-gas
branch
2 times, most recently
from
508a58d to
5d62635
Compare
qdm12
force-pushed
the
qdm12/libevm/legacy/precompile-gas
branch
from
5d62635 to
fe5c0bd
Compare
qdm12
force-pushed
the
qdm12/libevm/legacy/precompile-gas
branch
from
fe5c0bd to
6a8fb2e
Compare
ARR4N
requested changes
Feb 4, 2025
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com> Signed-off-by: Quentin McGaw <quentin.mcgaw@gmail.com>
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com> Signed-off-by: Quentin McGaw <quentin.mcgaw@gmail.com>
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com> Signed-off-by: Quentin McGaw <quentin.mcgaw@gmail.com>
2 tasks
3 tasks
darioush
approved these changes
Feb 4, 2025
darioush
left a comment
darioush
left a comment
There was a problem hiding this comment.
this LGTM.
I think it is best to have some form of testing that ensures changes to libevm (esp in core/vm) do not break coreth, as in the past the UTs have shown to not be sufficient to catch all cases.
ARR4N
requested changes
Feb 5, 2025
ARR4N
reviewed
Feb 5, 2025
ARR4N
approved these changes
Feb 6, 2025
Collaborator
ARR4N
left a comment
ARR4N
left a comment
There was a problem hiding this comment.
One necessary change before merging, please, but otherwise LGTM
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com> Signed-off-by: Quentin McGaw <quentin.mcgaw@gmail.com>
ARR4N
approved these changes
Feb 6, 2025
Collaborator
ARR4N
left a comment
ARR4N
left a comment
There was a problem hiding this comment.
I like the change of gas accounting to align with reality. Suggested a field name to go with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Following refactor in #73 and a quick-fix on #104 this adds 2 fixes to
PrecompiledStatefulContractHow this works
How this was tested
New test and
vm.PrecompileEnvironmentstub