Open
Conversation
7 tasks
JonathanOppenheimer
force-pushed
the
JonathanOppenheimer/nonce-rpcs
branch
3 times, most recently
from
a8a7b67 to
eeb398e
Compare
JonathanOppenheimer
added
the
DO NOT MERGE
ceyonur
force-pushed
the
ceyonur/gasprice-api
branch
from
8cc0949 to
65abb83
Compare
JonathanOppenheimer
force-pushed
the
JonathanOppenheimer/nonce-rpcs
branch
2 times, most recently
from
daea4bb to
97f08b5
Compare
JonathanOppenheimer
force-pushed
the
JonathanOppenheimer/nonce-rpcs
branch
from
97f08b5 to
eac6cee
Compare
JonathanOppenheimer
removed
the
DO NOT MERGE
JonathanOppenheimer
requested review from
ARR4N and
StephenButtolph
as code owners
JonathanOppenheimer
added
the
DO NOT MERGE
Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
JonathanOppenheimer
removed
the
DO NOT MERGE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #104.
Adds
GetPoolNonce, which, on top of the gas RPCs, allows us to support 3 additional RPCs:eth_getTransactionCounteth_fillTransactioneth_resendI added a separate short unit test for each of these RPCs, as I couldn't find a neat way to fit them into any existing tests. Test
EthGettersis not appropriate foreth_getTransactionCountIMO.