Updated python and sphinx-needs#77
Updated python and sphinx-needs#77PhilipPartsch wants to merge 6 commits intoavengineers:developfrom
Conversation
xxthunder
left a comment
xxthunder
left a comment
There was a problem hiding this comment.
Thank you very much for this contribution. Only minor findings to be solved before merge. 🦆
| from pathlib import Path | ||
| from subprocess import CalledProcessError | ||
| from typing import Any, Dict, Iterable, Iterator, List, Optional, Set, Tuple, Union | ||
| from typing import Any |
There was a problem hiding this comment.
Why is this required? typing classes are bad?
| #### Quick Start | ||
| ```bash | ||
| # Using Makefile | ||
| make setup # Install dependencies and setup hooks |
There was a problem hiding this comment.
No GNU Make please. We banned this from all our projects.
|
|
||
|
|
||
| def run_process(args: List[str], cwd: Optional[str] = None) -> int: | ||
| def run_process(args: list[str], cwd: str | None = None) -> int: |
There was a problem hiding this comment.
Same here? Python 3.13 does not like that anymore?
| # Set the version of Python and other tools you might need | ||
| build: | ||
| os: ubuntu-20.04 | ||
| os: ubuntu-22.04 |
There was a problem hiding this comment.
Thanks for updating this. 24.04 is not available yet?
| files: | | ||
| out/test-report.xml | ||
|
|
||
| test-on-linux: |
There was a problem hiding this comment.
When you propose to use build.sh on linux (what I really like and support), then please update this workflow to use and test it.
| cd hammocking | ||
|
|
||
| # Make build script executable | ||
| chmod +x build.sh |
There was a problem hiding this comment.
Please remove this and update build.sh to be executable.
Hint: git update-index --chmod=+x build.sh
| @@ -0,0 +1,161 @@ | |||
| .PHONY: help install clean build test lint docs run all | |||
There was a problem hiding this comment.
No way we allow a Makefile in here. ;-)
|
I enabled the workflow, please have a look there, too. |
|
@PhilipPartsch And conflicts, oh boy. Sorry for that. |
3 participants
We updated python and sphinx-needs.
We do had to fix linter and ruff warnings, too.