Skip to content

Conversation

@gaebor
Copy link

@gaebor gaebor commented Mar 10, 2018

No description provided.

@avih
Copy link
Owner

avih commented Mar 13, 2018

Thanks for the patches.

To be honest, I actually prefer to remove unused code rather than adding more, i.e. make it even simpler.

As you see from the commit log, beyond my initial effort to clean it up, add the directory listing stuff, and making it behave nicer across platforms (and I do use it on more than one platform), it's been mostly stagnant except for rare minor fixes.

I don't plan to develop it further in a meaningful way, so not sure what to do with this PR - it does add meaningful features which someone would need to maintain.

If you do plan to develop it further though, I can add a link at my readme to your fork at some stage. What say you?

@gaebor
Copy link
Author

gaebor commented Mar 13, 2018

Don't accept if you don't want to.

I'm not sure that I'll develop myself, but your patches and fixes helped a lot.
The original stanleyhuang implementation didn't even work for (windows) x64.

thx anyway

@avih
Copy link
Owner

avih commented Mar 13, 2018

OK. I don't plan to merge these patches, but I'll leave leave the PR open at least for a while, in case someone wants to discuss it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants