Skip to content

Fixed code bug in creating agent with KB example#632

Open
shaniru-aws wants to merge 1 commit intoaws-samples:mainfrom
shaniru-aws:shaniru-feature-examples-04-bug-fix
Open

Fixed code bug in creating agent with KB example#632
shaniru-aws wants to merge 1 commit intoaws-samples:mainfrom
shaniru-aws:shaniru-feature-examples-04-bug-fix

Conversation

@shaniru-aws
Copy link

Issue #, if available:

When attempting to create OpenSearch index the code kept failing on the command open_search_client.indices.create() due to parameter issues.

Description of changes:

The create() method expects the index name as a keyword argument, not a positional argument. The code shared in the notebook is incorrect and kept returning the following error whenever executed :

TypeError                                 Traceback (most recent call last)
Cell In[31], line 52
     47 index_body["mappings"]["properties"][kb_metadataField] = {
     48     "type": "text"
     49 }
     51 # Create index
---> 52 response = open_search_client.indices.create(kb_vector_index_name, body=index_body)
     53 print('\nCreating index:')
     54 print(response)

File /opt/conda/lib/python3.12/site-packages/opensearchpy/client/utils.py:176, in query_params.<locals>._wrapper.<locals>._wrapped(*args, **kwargs)
    173         if v is not None:
    174             params[p] = _escape(v)
—> 176 return func(*args, params=params, headers=headers, **kwargs)

TypeError: IndicesClient.create() takes 1 positional argument but 2 positional arguments (and 3 keyword-only arguments) were given

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shaniru-aws shaniru-aws marked this pull request as draft August 16, 2025 07:22
@shaniru-aws shaniru-aws marked this pull request as ready for review August 16, 2025 07:22
@shaniru-aws
Copy link
Author

#633

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant