This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Change to list only SNS subscriptions by subscribed topic#5
Open
jveldboom wants to merge 1 commit intoaws-samples:masterfrom
Open
Change to list only SNS subscriptions by subscribed topic#5jveldboom wants to merge 1 commit intoaws-samples:masterfrom
jveldboom wants to merge 1 commit intoaws-samples:masterfrom
Conversation
|
Why do you need the subscription at all? You're just reading the TopicArn that you passed in |
|
Agree. No need to check subscriptions. Just publish straight away. |
|
This should be closed in favour of PR #14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to loop over just the subscribed SNS topic in the event.
Also by default
list_subscriptions()returns 100 subscriptions at a time. So if you have more than 100, it might not find the correct subscription.