Skip to content

fix: resolve lint warnings#338

Merged
jesseturner21 merged 1 commit intomainfrom
fix/lint-warnings
Feb 19, 2026
Merged

fix: resolve lint warnings#338
jesseturner21 merged 1 commit intomainfrom
fix/lint-warnings

Conversation

@notgitika
Copy link
Contributor

Summary

  • Disable false-positive security rules (detect-non-literal-fs-filename, detect-object-injection) globally in ESLint config — these are expected for a CLI tool that works with dynamic file paths and Record lookups (416 warnings)
  • Remove stale eslint-disable inline comments that became unnecessary after the global disables and from prior rule removals (13 files)
  • Fix react-hooks/exhaustive-deps by adding missing dependencies to useEffect arrays
  • Fix security/detect-unsafe-regex by rewriting the Gateway name regex and suppressing safe bounded regexes
  • Suppress react-refresh/only-export-components for intentional co-located utility exports
  • Suppress react-hooks/preserve-manual-memoization for stable process-lifetime memoization

Test plan

  • npm run lint — 0 warnings (down from 437)
  • npm run typecheck — passes
  • npm run format:check — passes
  • npm test — no new failures (14 pre-existing failures on main)

@notgitika notgitika requested a review from a team February 18, 2026 19:30
@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 41.28% 2657 / 6435
🔵 Statements 40.74% 2786 / 6838
🔵 Functions 43.52% 571 / 1312
🔵 Branches 46.81% 1765 / 3770
Generated in workflow #428 for commit d972745 by the Vitest Coverage Report Action

@jesseturner21 jesseturner21 merged commit 8579540 into main Feb 19, 2026
15 checks passed
@jesseturner21 jesseturner21 deleted the fix/lint-warnings branch February 19, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants