fix: handle unhandled promise rejection in vended CDK main()#409
Merged
fix: handle unhandled promise rejection in vended CDK main()#409
Conversation
notgitika
had a problem deploying
to
e2e-testing
GitHub Actions
Failure
notgitika
force-pushed
the
fix/cdk-unhandled-promise
branch
from
6a1321b to
d294572
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
.catch()handler to the baremain()call in the vendedcdk/bin/cdk.ts. Without this, any error during config reading or stack construction produces an opaqueUnhandledPromiseRejectioninstead of a clear message.Closes #408
Type of Change
Testing
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshots