fix: gateway-target CLI bugs and enable gateway test coverage#487
Closed
aidandaly24 wants to merge 3 commits intomainfrom
Closed
fix: gateway-target CLI bugs and enable gateway test coverage#487aidandaly24 wants to merge 3 commits intomainfrom
aidandaly24 wants to merge 3 commits intomainfrom
Conversation
…point - Pass source/type/endpoint options through command.tsx to handler (were silently dropped, breaking --source existing-endpoint) - Default source to 'existing-endpoint' in validation (only supported path) - Reject 'create-new' source with clear error message - Move outbound auth validation before source branching so it applies to existing-endpoint targets (was unreachable due to early return)
- Unskip all 4 gateway test files (add/remove gateway/gateway-target) - Update validGatewayTargetOptions fixture to existing-endpoint - Remove create-new path tests (not user-facing yet) - Add tests: rejects create-new source, requires endpoint, invalid OAuth discovery URL, auto-create OAuth credential - Rewrite cascade/removal tests to use --endpoint instead of non-existent 'add bind gateway' and --language/--host flags
- Add end-to-end gateway lifecycle test (add gateway, add target with Exa MCP endpoint, remove target, remove gateway) - Add unit tests for getGatewayEnvVars (dev environment setup)
Contributor
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enables comprehensive test coverage for the gateway integration feature. All gateway tests were previously skipped (describe.skip) and several contained pre-alpha assumptions that no longer match the implementation.
Changes:
Depends on #
Related Issue
Closes #
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.