fix: wire gateway-target CLI flags and default source to existing-endpoint#488
Open
aidandaly24 wants to merge 1 commit intomainfrom
Open
fix: wire gateway-target CLI flags and default source to existing-endpoint#488aidandaly24 wants to merge 1 commit intomainfrom
aidandaly24 wants to merge 1 commit intomainfrom
Conversation
…point - Pass source/type/endpoint options through command.tsx to handler (were silently dropped, breaking --source existing-endpoint) - Default source to 'existing-endpoint' in validation (only supported path) - Reject 'create-new' source with clear error message - Move outbound auth validation before source branching so it applies to existing-endpoint targets (was unreachable due to early return)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes three bugs in the gateway-target CLI non-interactive path that made agentcore add gateway-target non-functional from the CLI:
Source code fixes:
command.tsx: Wiresource,type, andendpointoptions through to the handler (were silently dropped, making--source existing-endpoint --endpoint <url>non-functional from CLI)validate.ts: Defaultsourceto'existing-endpoint'when not provided, matching TUI behavior (only supported path currently)validate.ts: Reject--source create-newwith a clear error message instead of falling through to unimplemented codevalidate.ts: Move outbound auth validation before source-specific branching so credential/OAuth checks apply to existing-endpoint targets (was unreachable due to early return)After this fix, agentcore
add gateway-target --name foo --endpoint https://example.com/mcp --gateway bar --jsonworks as expected. Test coverage follows in a separate PR.Related Issue
Closes #
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.