Open
Conversation
…h AutoMonitor and AnnotationMutators, check if safe to mutate before applying custom selector, run opt out tests for each type of workload, test opt out by disabling monitorallservices
CustomSelectors should obey autoRestart, autoAnnotateAutoInstrumentation shouldn't. Rename MonitorInterface to InstrumentationAnnotator. Add docs.
…ntation container validation by default. This is required for automonitor to work, because it tries to apply all init containers to each selected pod.
… update pod templates in workloads.
…el custom selector should not update pod template
…art namespace for autoAnnotateAutoInstrumentation.
Contributor
|
will fail/be flakey until #311 is merged in |
* Implement patching and workload informers * Update EnableMultiInstrumentationSupport and SkipMultiInstrumentationContainerValidation feature flags to be enabled by default * incorporate feedback
the-mann
reviewed
May 22, 2025
the-mann
reviewed
May 22, 2025
the-mann
reviewed
May 22, 2025
the-mann
reviewed
May 22, 2025
the-mann
reviewed
May 22, 2025
the-mann
reviewed
May 22, 2025
the-mann
reviewed
May 22, 2025
the-mann
reviewed
May 22, 2025
the-mann
reviewed
May 22, 2025
the-mann
changed the title
Contributor
|
reopening to see status of integ tests |
the-mann
changed the title
lisguo
reviewed
Sep 29, 2025
| run: | | ||
| cd integration-tests/manifests/automonitor/ && \ | ||
| echo "tests<<EOF" >> $GITHUB_OUTPUT | ||
| go test -list . | sed -e '$d' >> $GITHUB_OUTPUT |
Contributor
There was a problem hiding this comment.
nit, can we call the test directly using absolute path?
Suggested change
| go test -list . | sed -e '$d' >> $GITHUB_OUTPUT | |
| go test -list integration-tests/manifest/automonitor/ | sed -e '$d' >> $GITHUB_OUTPUT |
| - name: Start minikube | ||
| uses: medyagh/setup-minikube@master | ||
|
|
||
| - name: Deploy cert-manager to minikube |
Contributor
There was a problem hiding this comment.
nit: at some point we should combine the start minikube, deploy cert-manager, and verify minikube and cert manager steps into their own workflow since they're used everywhere
| } | ||
| } | ||
| // sleep to give pods time to come up | ||
| time.Sleep(20 * time.Second) |
| h.updateOperatorConfig(deploymentArg{jsonStr, "--auto-annotation-config="}) | ||
| } | ||
|
|
||
| func (h *TestHelper) updateOperatorConfig(argList ...deploymentArg) { |
Contributor
There was a problem hiding this comment.
Instead of modifying an existing operator deployment can't we apply a deployment object? or use yaml to force an update on the operator?
| flag string | ||
| } | ||
|
|
||
| func (h *TestHelper) ValidateNamespaceAnnotations(namespace string, shouldExist []string, shouldNotExist []string) error { |
Contributor
There was a problem hiding this comment.
instead of having a shouldNotExist parameter, can't we just strictly check the shouldExist? Maybe we have some filter to only look at auto annotate prefixes?
| @@ -0,0 +1,32 @@ | |||
| apiVersion: apps/v1 | |||
Contributor
There was a problem hiding this comment.
all of these manifests are pretty much identical but just different names. Can we re-use just 1?
musa-asad
reviewed
Oct 6, 2025
| const TimeBetweenRetries = 5 * time.Second | ||
|
|
||
| // WaitForNewPodCreation takes in a resource either Deployment, DaemonSet, or StatefulSet wait until it is in running stage | ||
| func WaitForNewPodCreation(clientSet *kubernetes.Clientset, resource interface{}, startTime time.Time) error { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
mainBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.