feat(cli): add publish command for asset publishing#1020
Open
feat(cli): add publish command for asset publishing#1020
Conversation
go-to-k
had a problem deploying
to
integ-approval
GitHub Actions
Failure
go-to-k
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1020 +/- ##
==========================================
+ Coverage 87.76% 87.84% +0.07%
==========================================
Files 72 72
Lines 10137 10214 +77
Branches 1339 1344 +5
==========================================
+ Hits 8897 8972 +75
- Misses 1215 1217 +2
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
go-to-k
had a problem deploying
to
integ-approval
GitHub Actions
Failure
go-to-k
had a problem deploying
to
integ-approval
GitHub Actions
Failure
go-to-k
had a problem deploying
to
integ-approval
GitHub Actions
Failure
go-to-k
had a problem deploying
to
integ-approval
GitHub Actions
Failure
go-to-k
had a problem deploying
to
integ-approval
GitHub Actions
Failure
go-to-k
had a problem deploying
to
integ-approval
GitHub Actions
Failure
go-to-k
had a problem deploying
to
integ-approval
GitHub Actions
Failure
go-to-k
had a problem deploying
to
integ-approval
GitHub Actions
Failure
go-to-k
had a problem deploying
to
integ-approval
GitHub Actions
Failure
go-to-k
had a problem deploying
to
integ-approval
GitHub Actions
Failure
go-to-k
had a problem deploying
to
integ-approval
GitHub Actions
Failure
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
Contributor
Author
|
Tried to change it. Could you please take a look at it? |
mrgrain
reviewed
Feb 23, 2026
| }, | ||
| }, | ||
| }, | ||
| 'publish': { |
Contributor
There was a problem hiding this comment.
not sure about the name yet
Contributor
Author
There was a problem hiding this comment.
I see. Do you have any good ideas?
publish, build, release, upload, push, prepare, etc...
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
mrgrain
reviewed
Feb 23, 2026
| 'force': { type: 'boolean', alias: 'f', desc: 'Always publish assets, even if they are already published', default: false }, | ||
| 'asset-parallelism': { type: 'boolean', desc: 'Whether to build/publish assets in parallel' }, | ||
| 'concurrency': { type: 'number', desc: 'Maximum number of simultaneous asset publishing operations (dependency permitting) to execute.', default: 1, requiresArg: true }, | ||
| }, |
Contributor
There was a problem hiding this comment.
Isn't this the same setting?
Contributor
Author
There was a problem hiding this comment.
The deploy command's settings already have that configurations. The asset-parallelism determines "whether to parallelize or not," and concurrency determines the number of parallel processes.
However, they certainly look similar. I removed asset-parallelism.
mrgrain
reviewed
Feb 23, 2026
Comment on lines
514
to
542
| const buildAsset = async (assetNode: AssetBuildNode) => { | ||
| const buildAssetSpan = await ioHelper.span(SPAN.BUILD_ASSET).begin({ | ||
| asset: assetNode.asset, | ||
| }); | ||
| await deployments.buildSingleAsset( | ||
| assetNode.assetManifestArtifact, | ||
| assetNode.assetManifest, | ||
| assetNode.asset, | ||
| { | ||
| stack: assetNode.parentStack, | ||
| roleArn: options.roleArn, | ||
| stackName: assetNode.parentStack.stackName, | ||
| }, | ||
| ); | ||
| await buildAssetSpan.end(); | ||
| }; | ||
|
|
||
| const publishAsset = async (assetNode: AssetPublishNode) => { | ||
| const publishAssetSpan = await ioHelper.span(SPAN.PUBLISH_ASSET).begin({ | ||
| asset: assetNode.asset, | ||
| }); | ||
| await deployments.publishSingleAsset(assetNode.assetManifest, assetNode.asset, { | ||
| stack: assetNode.parentStack, | ||
| roleArn: options.roleArn, | ||
| stackName: assetNode.parentStack.stackName, | ||
| forcePublish: options.force, | ||
| }); | ||
| await publishAssetSpan.end(); | ||
| }; |
Contributor
There was a problem hiding this comment.
Lot's of duplication with _deploy() here. Let's find a way to reuse the same code.
Contributor
Author
There was a problem hiding this comment.
Created createBuildAssetFunction and createPublishAssetFunction.
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
Contributor
Author
|
I've updated them based on your feedback. |
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #982
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license