feat(cdk-assets-lib): support --build-context flag for docker image builds#1128
Open
feat(cdk-assets-lib): support --build-context flag for docker image builds#1128
Conversation
…uilds Add support for `dockerBuildContexts` in the cloud assembly schema and docker build logic. This allows passing additional named build contexts to the `docker build` command via the `--build-context` flag, enabling multi-context Docker builds where files can be sourced from directories, URLs, or other Docker images outside the primary build directory.
cogwirrel
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1128 +/- ##
=======================================
Coverage 87.71% 87.72%
=======================================
Files 72 72
Lines 10129 10129
Branches 1338 1338
=======================================
+ Hits 8885 8886 +1
+ Misses 1218 1217 -1
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cogwirrel
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
iankhou
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
Contributor
|
Hi @cogwirrel, thanks for the contribution! Can you add some details (logs, etc.) as to how you tested/verified this change? |
iankhou
requested changes
Feb 17, 2026
Contributor
iankhou
left a comment
iankhou
left a comment
There was a problem hiding this comment.
Please see comment on the PR, requesting verification of fix.
Member
Author
|
Hi @iankhou! Thanks for taking a look! I tested in conjunction with my PR to aws-cdk-lib here: aws/aws-cdk#36930 In that PR I added an integration test, and verified that it worked end to end with a linked copy of aws-cdk-cli. The key parts of the integration test were declaring the build context: const asset = new assets.DockerImageAsset(stack, 'DockerImageWithBuildContext', {
directory: path.join(__dirname, 'demo-image-build-context', 'image'),
buildContexts: {
mycontext: path.join(__dirname, 'demo-image-build-context', 'context'),
},
});And then using it in the Dockerfile: FROM public.ecr.aws/docker/library/python:3.12-slim
EXPOSE 8000
WORKDIR /src
ADD . /src
COPY --from=mycontext hello.txt /src/hello.txt
CMD ["python3", "index.py"]To deploy, my steps were roughly: Output: For a final end to end test, I created an ECS "Express Service" pointing at the image deployed by the integ test, and everything deployed successfully: 
(I've since torn the service down) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for
dockerBuildContextsin the cloud assembly schema and docker build logic. This allows passing additional named build contexts to thedocker buildcommand via the--build-contextflag, enabling multi-context Docker builds where files can be sourced from directories, URLs, or other Docker images outside the primary build directory.This PR adds the CLI changes required to address aws/aws-cdk#31598
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license