fix(mixins-preview): apply mixins in order#36847
Merged
mergify[bot] merged 3 commits intomainfrom Feb 3, 2026
Merged
Conversation
aws-cdk-automation
previously requested changes
Feb 3, 2026
rix0rrr
approved these changes
Feb 3, 2026
mrgrain
added
pr-linter/exempt-test
vishaalmehrishi
approved these changes
Feb 3, 2026
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify
bot
deleted the
mrgrain/fix/mixins-preview/apply-mixins-in-order
branch
Contributor
Merge Queue Status✅ The pull request has been merged at 6ac17b7 This pull request spent 10 seconds in the queue, with no time running CI. Required conditions to merge
|
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Related RFC: aws/aws-cdk-rfcs#824
Reason for this change
Aligns the implementation with the latest version of the Mixins RFC.
The
.with()method previously iterated over constructs first, then mixins. This meant that mixins were not guaranteed to be applied in the order they were passed to the method. Additionally, if a mixin added new constructs to the tree, subsequent mixins in the same call could unexpectedly visit those newly added constructs.Description of changes
Changed the loop order so that mixins are applied in order. The list of constructs is now captured at the start of the call, ensuring that constructs added by a mixin will not be visited by subsequent mixins. Users who need subsequent mixins to apply to added constructs can use multiple
.with()calls.Also improved variable naming for clarity (
c→construct,m→mixin).Describe any new or updated permissions being added
N/A
Description of how you validated changes
Existing tests pass. This behavior is explicitly tested in aws/constructs#2843.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license