Conversation
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| /** Version "13.00.6470.1.v1". */ | ||
| public static readonly VER_13_00_6470_1_V1 = SqlServerEngineVersion.of('13.00.6470.1.v1', '13.00'); | ||
| /** Version "13.00.6475.1.v1". */ | ||
| public static readonly VER_13_00_6475_1_V1 = SqlServerEngineVersion.of('13.00.6475.1.v1', '13.00'); |
There was a problem hiding this comment.
Should we mark all v13.x as deprecated?
There is a deprecation plan for ending support for SQL Server 2016 during this year. AWS began disabling the creation of such instance in Jan (docs).
When I check in the CLI, I see only v14.x+ versions listed:
$ aws rds describe-db-engine-versions --engine sqlserver-se --query "DBEngineVersions[*].[EngineVersion,DBEngineVersionDescription]" --output table --region us-east-1
----------------------------------------------------------
| DescribeDBEngineVersions |
+-------------------+------------------------------------+
| 14.00.3281.6.v1 | SQL Server 2017 14.00.3281.6.v1 |
| 14.00.3294.2.v1 | SQL Server 2017 14.00.3294.2.v1 |
| 14.00.3356.20.v1 | SQL Server 2017 14.00.3356.20.v1 |
| 14.00.3381.3.v1 | SQL Server 2017 14.00.3381.3.v1 |
| 14.00.3401.7.v1 | SQL Server 2017 14.00.3401.7.v1 |
| 14.00.3421.10.v1 | SQL Server 2017 14.00.3421.10.v1 |
| 14.00.3451.2.v1 | SQL Server 2017 14.00.3451.2.v1 |
| 14.00.3460.9.v1 | SQL Server 2017 14.00.3460.9.v1 |
| 14.00.3465.1.v1 | SQL Server 2017 14.00.3465.1.v1 |
| 14.00.3471.2.v1 | SQL Server 2017 14.00.3471.2.v1 |
| 14.00.3475.1.v1 | SQL Server 2017 14.00.3475.1.v1 |
| 14.00.3480.1.v1 | SQL Server 2017 14.00.3480.1.v1 |
| 14.00.3485.1.v1 | SQL Server 2017 14.00.3485.1.v1 |
| 14.00.3495.9.v1 | SQL Server 2017 14.00.3495.9.v1 |
| 14.00.3500.1.v1 | SQL Server 2017 14.00.3500.1.v1 |
| 14.00.3505.1.v1 | SQL Server 2017 14.00.3505.1.v1 |
| 14.00.3515.1.v1 | SQL Server 2017 14.00.3515.1.v1 |
| 15.00.4043.16.v1 | SQL Server 2019 15.00.4043.16.v1 |
| 15.00.4073.23.v1 | SQL Server 2019 15.00.4073.23.v1 |
| 15.00.4153.1.v1 | SQL Server 2019 15.00.4153.1.v1 |
| 15.00.4198.2.v1 | SQL Server 2019 15.00.4198.2.v1 |
| 15.00.4236.7.v1 | SQL Server 2019 15.00.4236.7.v1 |
| 15.00.4312.2.v1 | SQL Server 2019 15.00.4312.2.v1 |
| 15.00.4316.3.v1 | SQL Server 2019 15.00.4316.3.v1 |
| 15.00.4322.2.v1 | SQL Server 2019 15.00.4322.2.v1 |
| 15.00.4335.1.v1 | SQL Server 2019 15.00.4335.1.v1 |
| 15.00.4345.5.v1 | SQL Server 2019 15.00.4345.5.v1 |
| 15.00.4355.3.v1 | SQL Server 2019 15.00.4355.3.v1 |
| 15.00.4365.2.v1 | SQL Server 2019 15.00.4365.2.v1 |
| 15.00.4375.4.v1 | SQL Server 2019 15.00.4375.4.v1 |
| 15.00.4382.1.v1 | SQL Server 2019 15.00.4382.1.v1 |
| 15.00.4385.2.v1 | SQL Server 2019 15.00.4385.2.v1 |
| 15.00.4390.2.v1 | SQL Server 2019 15.00.4390.2.v1 |
| 15.00.4395.2.v1 | SQL Server 2019 15.00.4395.2.v1 |
| 15.00.4410.1.v1 | SQL Server 2019 15.00.4410.1.v1 |
| 15.00.4415.2.v1 | SQL Server 2019 15.00.4415.2.v1 |
| 15.00.4420.2.v1 | SQL Server 2019 15.00.4420.2.v1 |
| 15.00.4430.1.v1 | SQL Server 2019 15.00.4430.1.v1 |
| 15.00.4435.7.v1 | SQL Server 2019 15.00.4435.7.v1 |
| 15.00.4440.1.v1 | SQL Server 2019 15.00.4440.1.v1 |
| 15.00.4445.1.v1 | SQL Server 2019 15.00.4445.1.v1 |
| 15.00.4455.2.v1 | SQL Server 2019 15.00.4455.2.v1 |
| 16.00.4085.2.v1 | SQL Server 2022 16.00.4085.2.v1 |
| 16.00.4095.4.v1 | SQL Server 2022 16.00.4095.4.v1 |
| 16.00.4105.2.v1 | SQL Server 2022 16.00.4105.2.v1 |
| 16.00.4115.5.v1 | SQL Server 2022 16.00.4115.5.v1 |
| 16.00.4120.1.v1 | SQL Server 2022 16.00.4120.1.v1 |
| 16.00.4125.3.v1 | SQL Server 2022 16.00.4125.3.v1 |
| 16.00.4131.2.v1 | SQL Server 2022 16.00.4131.2.v1 |
| 16.00.4135.4.v1 | SQL Server 2022 16.00.4135.4.v1 |
| 16.00.4140.3.v1 | SQL Server 2022 16.00.4140.3.v1 |
| 16.00.4150.1.v1 | SQL Server 2022 16.00.4150.1.v1 |
| 16.00.4165.4.v1 | SQL Server 2022 16.00.4165.4.v1 |
| 16.00.4175.1.v1 | SQL Server 2022 16.00.4175.1.v1 |
| 16.00.4185.3.v1 | SQL Server 2022 16.00.4185.3.v1 |
| 16.00.4195.2.v1 | SQL Server 2022 16.00.4195.2.v1 |
| 16.00.4205.1.v1 | SQL Server 2022 16.00.4205.1.v1 |
| 16.00.4210.1.v1 | SQL Server 2022 16.00.4210.1.v1 |
| 16.00.4215.2.v1 | SQL Server 2022 16.00.4215.2.v1 |
| 16.00.4225.2.v1 | SQL Server 2022 16.00.4225.2.v1 |
| 16.00.4230.2.v1 | SQL Server 2022 16.00.4230.2.v1 |
| 16.00.4236.2.v1 | SQL Server 2022 16.00.4236.2.v1 |
+-------------------+------------------------------------+There was a problem hiding this comment.
Thanks for review as always !
When I check in the CLI, I see only v14.x+ versions listed:
it's different from what i can confirm on my end... - there are v13.x versions:
aws rds describe-db-engine-versions --engine sqlserver-se --query "DBEngineVersions[*].[EngineVersion,DBEngineVersionDescription]" --output table --region us-east-1
----------------------------------------------------------
| DescribeDBEngineVersions |
+-------------------+------------------------------------+
| 13.00.6300.2.v1 | SQL Server 2016 13.00.6300.2.v1 |
| 13.00.6419.1.v1 | SQL Server 2016 13.00.6419.1.v1 |
| 13.00.6430.49.v1 | SQL Server 2016 13.00.6430.49.v1 |
| 13.00.6435.1.v1 | SQL Server 2016 13.00.6435.1.v1 |
| 13.00.6441.1.v1 | SQL Server 2016 13.00.6441.1.v1 |
| 13.00.6445.1.v1 | SQL Server 2016 13.00.6445.1.v1 |
| 13.00.6450.1.v1 | SQL Server 2016 13.00.6450.1.v1 |
| 13.00.6455.2.v1 | SQL Server 2016 13.00.6455.2.v1 |
| 13.00.6460.7.v1 | SQL Server 2016 13.00.6460.7.v1 |
| 13.00.6465.1.v1 | SQL Server 2016 13.00.6465.1.v1 |
| 13.00.6470.1.v1 | SQL Server 2016 13.00.6470.1.v1 |
| 13.00.6475.1.v1 | SQL Server 2016 13.00.6475.1.v1 |
| 14.00.3281.6.v1 | SQL Server 2017 14.00.3281.6.v1 |
| 14.00.3294.2.v1 | SQL Server 2017 14.00.3294.2.v1 |
| 14.00.3356.20.v1 | SQL Server 2017 14.00.3356.20.v1 |
| 14.00.3381.3.v1 | SQL Server 2017 14.00.3381.3.v1 |
| 14.00.3401.7.v1 | SQL Server 2017 14.00.3401.7.v1 |
| 14.00.3421.10.v1 | SQL Server 2017 14.00.3421.10.v1 |
| 14.00.3451.2.v1 | SQL Server 2017 14.00.3451.2.v1 |
| 14.00.3460.9.v1 | SQL Server 2017 14.00.3460.9.v1 |
| 14.00.3465.1.v1 | SQL Server 2017 14.00.3465.1.v1 |
| 14.00.3471.2.v1 | SQL Server 2017 14.00.3471.2.v1 |
| 14.00.3475.1.v1 | SQL Server 2017 14.00.3475.1.v1 |
| 14.00.3480.1.v1 | SQL Server 2017 14.00.3480.1.v1 |
| 14.00.3485.1.v1 | SQL Server 2017 14.00.3485.1.v1 |
| 14.00.3495.9.v1 | SQL Server 2017 14.00.3495.9.v1 |
| 14.00.3500.1.v1 | SQL Server 2017 14.00.3500.1.v1 |
| 14.00.3505.1.v1 | SQL Server 2017 14.00.3505.1.v1 |
| 14.00.3515.1.v1 | SQL Server 2017 14.00.3515.1.v1 |
| 15.00.4043.16.v1 | SQL Server 2019 15.00.4043.16.v1 |
| 15.00.4073.23.v1 | SQL Server 2019 15.00.4073.23.v1 |
| 15.00.4153.1.v1 | SQL Server 2019 15.00.4153.1.v1 |
| 15.00.4198.2.v1 | SQL Server 2019 15.00.4198.2.v1 |
| 15.00.4236.7.v1 | SQL Server 2019 15.00.4236.7.v1 |
| 15.00.4312.2.v1 | SQL Server 2019 15.00.4312.2.v1 |
| 15.00.4316.3.v1 | SQL Server 2019 15.00.4316.3.v1 |
| 15.00.4322.2.v1 | SQL Server 2019 15.00.4322.2.v1 |
| 15.00.4335.1.v1 | SQL Server 2019 15.00.4335.1.v1 |
| 15.00.4345.5.v1 | SQL Server 2019 15.00.4345.5.v1 |
| 15.00.4355.3.v1 | SQL Server 2019 15.00.4355.3.v1 |
| 15.00.4365.2.v1 | SQL Server 2019 15.00.4365.2.v1 |
| 15.00.4375.4.v1 | SQL Server 2019 15.00.4375.4.v1 |
| 15.00.4382.1.v1 | SQL Server 2019 15.00.4382.1.v1 |
| 15.00.4385.2.v1 | SQL Server 2019 15.00.4385.2.v1 |
| 15.00.4390.2.v1 | SQL Server 2019 15.00.4390.2.v1 |
| 15.00.4395.2.v1 | SQL Server 2019 15.00.4395.2.v1 |
| 15.00.4410.1.v1 | SQL Server 2019 15.00.4410.1.v1 |
| 15.00.4415.2.v1 | SQL Server 2019 15.00.4415.2.v1 |
| 15.00.4420.2.v1 | SQL Server 2019 15.00.4420.2.v1 |
| 15.00.4430.1.v1 | SQL Server 2019 15.00.4430.1.v1 |
| 15.00.4435.7.v1 | SQL Server 2019 15.00.4435.7.v1 |
| 15.00.4440.1.v1 | SQL Server 2019 15.00.4440.1.v1 |
| 15.00.4445.1.v1 | SQL Server 2019 15.00.4445.1.v1 |
| 15.00.4455.2.v1 | SQL Server 2019 15.00.4455.2.v1 |
| 16.00.4085.2.v1 | SQL Server 2022 16.00.4085.2.v1 |
| 16.00.4095.4.v1 | SQL Server 2022 16.00.4095.4.v1 |
| 16.00.4105.2.v1 | SQL Server 2022 16.00.4105.2.v1 |
| 16.00.4115.5.v1 | SQL Server 2022 16.00.4115.5.v1 |
| 16.00.4120.1.v1 | SQL Server 2022 16.00.4120.1.v1 |
| 16.00.4125.3.v1 | SQL Server 2022 16.00.4125.3.v1 |
| 16.00.4131.2.v1 | SQL Server 2022 16.00.4131.2.v1 |
| 16.00.4135.4.v1 | SQL Server 2022 16.00.4135.4.v1 |
| 16.00.4140.3.v1 | SQL Server 2022 16.00.4140.3.v1 |
| 16.00.4150.1.v1 | SQL Server 2022 16.00.4150.1.v1 |
| 16.00.4165.4.v1 | SQL Server 2022 16.00.4165.4.v1 |
| 16.00.4175.1.v1 | SQL Server 2022 16.00.4175.1.v1 |
| 16.00.4185.3.v1 | SQL Server 2022 16.00.4185.3.v1 |
| 16.00.4195.2.v1 | SQL Server 2022 16.00.4195.2.v1 |
| 16.00.4205.1.v1 | SQL Server 2022 16.00.4205.1.v1 |
| 16.00.4210.1.v1 | SQL Server 2022 16.00.4210.1.v1 |
| 16.00.4215.2.v1 | SQL Server 2022 16.00.4215.2.v1 |
| 16.00.4225.2.v1 | SQL Server 2022 16.00.4225.2.v1 |
| 16.00.4230.2.v1 | SQL Server 2022 16.00.4230.2.v1 |
| 16.00.4236.2.v1 | SQL Server 2022 16.00.4236.2.v1 |
+-------------------+------------------------------------+
However, I also checked the ap-northeast-1 region, no v13.x versions available there.
There is a deprecation plan for ending support for SQL Server 2016 during this year. AWS began disabling the creation of such instance in Jan (docs).
As you mentioned above, we probably shouldn’t include v13.x versions anymore.
Instead, we could mark the v13 series as @deprecated.
what do you think?
There was a problem hiding this comment.
we could mark the v13 series as @deprecated
Agree. For clarity, I would add the deprecation docs shared above to the deprecation note of public static readonly VER_13 = SqlServerEngineVersion.of('13.00', '13.00'); only.
There was a problem hiding this comment.
I added reference to doc.
@deprecated SQL Server 13.00 is no longer supported by Amazon RDS. See https://repost.aws/articles/ARGkeWligDSU-MQgBwUQj0nA
| /** Version "13.00" (only a major version, without a specific minor version). */ | ||
| /** | ||
| * Version "13.00" (only a major version, without a specific minor version). | ||
| * @deprecated SQL Server 13.00 is no longer supported by Amazon RDS. See https://repost.aws/articles/ARGkeWligDSU-MQgBwUQj0nA |
There was a problem hiding this comment.
| * @deprecated SQL Server 13.00 is no longer supported by Amazon RDS. See https://repost.aws/articles/ARGkeWligDSU-MQgBwUQj0nA | |
| * @deprecated SQL Server 13.00 is no longer supported by Amazon RDS | |
| * @see https://repost.aws/articles/ARGkeWligDSU-MQgBwUQj0nA |
Annotation usage.
| public static readonly VER_13_00_6300_2_V1 = SqlServerEngineVersion.of('13.00.6300.2.v1', '13.00'); | ||
| /** Version "13.00.6419.1.v1". */ | ||
| public static readonly VER_13_00_6419_1_V1 = SqlServerEngineVersion.of('13.00.6419.1.v1', '13.00'); | ||
| /** Version "13.00.6430.49.v1". */ | ||
| public static readonly VER_13_00_6430_49_V1 = SqlServerEngineVersion.of('13.00.6430.49.v1', '13.00'); | ||
| /** Version "13.00.6435.1.v1". */ | ||
| public static readonly VER_13_00_6435_1_V1 = SqlServerEngineVersion.of('13.00.6435.1.v1', '13.00'); | ||
| /** Version "13.00.6441.1.v1". */ | ||
| public static readonly VER_13_00_6441_1_V1 = SqlServerEngineVersion.of('13.00.6441.1.v1', '13.00'); | ||
| /** Version "13.00.6445.1.v1". */ | ||
| public static readonly VER_13_00_6445_1_V1 = SqlServerEngineVersion.of('13.00.6445.1.v1', '13.00'); | ||
| /** Version "13.00.6450.1.v1". */ | ||
| public static readonly VER_13_00_6450_1_V1 = SqlServerEngineVersion.of('13.00.6450.1.v1', '13.00'); | ||
| /** Version "13.00.6455.2.v1". */ | ||
| public static readonly VER_13_00_6455_2_V1 = SqlServerEngineVersion.of('13.00.6455.2.v1', '13.00'); | ||
| /** Version "13.00.6460.7.v1". */ | ||
| public static readonly VER_13_00_6460_7_V1 = SqlServerEngineVersion.of('13.00.6460.7.v1', '13.00'); | ||
| /** Version "13.00.6465.1.v1". */ | ||
| public static readonly VER_13_00_6465_1_V1 = SqlServerEngineVersion.of('13.00.6465.1.v1', '13.00'); | ||
| /** Version "13.00.6470.1.v1". */ | ||
| public static readonly VER_13_00_6470_1_V1 = SqlServerEngineVersion.of('13.00.6470.1.v1', '13.00'); |
There was a problem hiding this comment.
I think these should be marked for deprecation as well. Also, 13.00.6475.1.v1 should be kept for completeness even if deprecated. What do you think?
Issue
Closes #36993
Reason for this change
RDS now supports newer cumulative updates (CU) and GDR updates for Microsoft SQL Server.
Description of changes
Added new SQL Server engine version
SQL Server 2022 (16.00):
VER_16_00_4225_2_V1(CU22)VER_16_00_4230_2_V1(CU22 GDR)VER_16_00_4236_2_V1(CU23)SQL Server 2019 (15.00):
VER_15_00_4455_2_V1(CU32 GDR)SQL Server 2017 (14.00):
VER_14_00_3515_1_V1(CU31 GDR)SQL Server 2016 (13.00):
VER_13_00_6475_1_V1(GDR)Describe any new or updated permissions being added
None
Description of how you validated changes
Confirmed version strings match AWS RDS documentation
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license