chore(spec2cdk): handle undefined properties in the reference interfaces#37040
Open
leonmk-aws wants to merge 1 commit intomainfrom
Open
chore(spec2cdk): handle undefined properties in the reference interfaces#37040leonmk-aws wants to merge 1 commit intomainfrom
leonmk-aws wants to merge 1 commit intomainfrom
Conversation
Collaborator
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #.
Reason for this change
When a ref interface property is optional (e.g. workteamName?: string), the generated constructor code that extracts values from ref objects via optional chaining (?.ref?.property) would cause a compile time error.
Description of changes
Added
getRefPropertyutility that extracts a property from a ref object and throws a TypeError if the ref exists but the target property is undefined. Returns undefined when the ref itself is null, allowing ?? fallback chains to work naturally.Added overloads to ensureStringOrUndefined so TypeScript correctly narrows the return type:
Before
After
Description of how you validated changes
Added unit tests for the new function.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license