fix(logs): correct metric name in metricIncomingLogEvents#37068
Open
fix(logs): correct metric name in metricIncomingLogEvents#37068
Conversation
The `metricIncomingLogEvents()` method was returning a metric with name 'IncomingLogs' instead of the correct AWS CloudWatch Logs metric name 'IncomingLogEvents'. This fix changes the metric name to match the actual AWS CloudWatch metric name as documented in AWS CloudWatch Logs documentation. Added unit tests for `metricIncomingLogEvents()`, `metricIncomingBytes()`, and the base `metric()` method to prevent regression. Closes aws#36815. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: abhu85 <60182103+abhu85@users.noreply.github.com>
github-actions
bot
added
bug
aws-cdk-automation
requested changes
Feb 24, 2026
Collaborator
aws-cdk-automation
left a comment
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #36815.
Reason for this change
The
metricIncomingLogEvents()method returns a metric with the wrong name'IncomingLogs'instead of the correct AWS CloudWatch Logs metric name'IncomingLogEvents'.This causes users to monitor a non-existent metric, resulting in no data being collected when they expect to see incoming log event counts.
Description of changes
Changed the metric name in
metricIncomingLogEvents()from'IncomingLogs'to'IncomingLogEvents'to match the actual AWS CloudWatch metric name.Added unit tests for:
metricIncomingLogEvents()- verifies correct metric namemetricIncomingBytes()- verifies correct metric namemetric()- verifies custom metric name handlingDescribe any new or updated permissions being added
None.
Description of how you validated changes
Verified the fix matches the AWS CloudWatch Logs documentation which lists the correct metric name as
IncomingLogEvents.Added unit tests that verify:
metricIncomingLogEvents()method returns a metric withmetricName: 'IncomingLogEvents'metricIncomingBytes()method returns a metric withmetricName: 'IncomingBytes''AWS/Logs'and default statistic'Sum'Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license