chore(autoscaling): fix integ tests - update deprecated AL1/t2/LaunchConfig to AL2/t3/LaunchTemplate#37074
Open
aemada-aws wants to merge 1 commit intomainfrom
Open
chore(autoscaling): fix integ tests - update deprecated AL1/t2/LaunchConfig to AL2/t3/LaunchTemplate#37074aemada-aws wants to merge 1 commit intomainfrom
aemada-aws wants to merge 1 commit intomainfrom
Conversation
…nfig to AL2/t3/LaunchTemplate - integ.asg-lc: Remove AUTOSCALING_GENERATE_LAUNCH_TEMPLATE=false (deprecated LC path), update AL1→AL2, fix deviceName 'ebs'→'/dev/xvdf' for LT compatibility - integ.asg-w-classic-loadbalancer: Update AL1→AL2, t2→t3 - integ.asg-w-elbv2: Update AL1→AL2, t2→t3 in both stacks BREAKING CHANGE: integ.asg-lc destroys LaunchConfiguration resource (replaced by LaunchTemplate)
aemada-aws
changed the title
Contributor
|
|
||||||||||||||||||||||||||
Contributor
|
|
||||||||||||||||||||||||||
aws-cdk-automation
added
the
pr/needs-maintainer-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
N/A — Integration test remediation
Reason for this change
Three
aws-autoscalingintegration tests are failing:"The Launch Configuration creation operation is not available in your account."— The test explicitly setAUTOSCALING_GENERATE_LAUNCH_TEMPLATE=false, forcing deprecated LaunchConfiguration creation which is no longer available."The requested configuration is currently not supported. Launching EC2 instance failed."— Uses deprecated Amazon Linux 1 AMI (EOL since 2024-01-01) and t2 instance type.Description of changes
integ.asg-lc.ts:
AUTOSCALING_GENERATE_LAUNCH_TEMPLATE=falsecontext override — the last ASG (AsgWithGp3Blockdevice) now generates a LaunchTemplate instead of a deprecated LaunchConfigurationAmazonLinuxImage()(AL1) →AmazonLinuxImage({ generation: AMAZON_LINUX_2 })for the last ASGdeviceName: 'ebs'→deviceName: '/dev/xvdf'— the old name was valid for LaunchConfiguration but not for LaunchTemplateinteg.asg-w-classic-loadbalancer.ts:
AmazonLinuxImage()→AmazonLinuxImage({ generation: AMAZON_LINUX_2 })BURSTABLE2(t2.micro) →BURSTABLE3(t3.micro)integ.asg-w-elbv2.ts:
AmazonLinuxImage()→AmazonLinuxImage({ generation: AMAZON_LINUX_2 })in both stacksBURSTABLE2→BURSTABLE3in ElbV2AsgStackDestructive changes:
integ.asg-lcdestroysAsgWithGp3BlockdeviceLaunchConfig24411F5E(LaunchConfiguration) and replaces it with a LaunchTemplate. This is intentional — LaunchConfigurations are deprecated and cannot be created in newer AWS accounts.Describe any new or updated permissions being added
N/A
Description of how you validated changes
All 3 tests passed across us-east-1, us-west-2, eu-west-1.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license