Skip to content

Conversation

@ofek
Copy link

@ofek ofek commented Jan 15, 2026

Hello team! I noticed the issue while investigating potential adoption. The porting guide refactor in #1463 missed this.

I also took the liberty of splitting the affected run-on sentence.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@ofek ofek requested a review from a team as a code owner January 15, 2026 17:03
@justsmth justsmth enabled auto-merge (squash) January 15, 2026 17:11
@justsmth
Copy link
Contributor

Thanks for the PR!

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.22%. Comparing base (1494e78) to head (9c92dfb).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2945   +/-   ##
=======================================
  Coverage   78.21%   78.22%           
=======================================
  Files         690      690           
  Lines      118750   118750           
  Branches    16680    16679    -1     
=======================================
+ Hits        92881    92892   +11     
+ Misses      24981    24968   -13     
- Partials      888      890    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth
Copy link
Contributor

justsmth commented Jan 16, 2026

Hi -- we have a required CI job failing due to the license statement not being found in the PR description. If you agree, would you add the following statement to this description:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

I can then rerun this job and get this merged. Thanks!

@ofek
Copy link
Author

ofek commented Jan 16, 2026

Sure thing, I updated the PR description accordingly!

@geedo0
Copy link
Contributor

geedo0 commented Jan 20, 2026

/codebuild_run(9c92dfb)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants