Merged
Conversation
initial patch and implementation up to getting the unsynced extensions and showing them in a dropdown menu
Add installation logic. Everything should work now
remove parallel installs due to race condition with writing obsolete file
aws-zamesjhu
approved these changes
Apr 11, 2025
aws-asolidu
approved these changes
Apr 11, 2025
| // get installed extensions. this could be different from pvExtensions b/c vscode sometimes doesn't delete the assets | ||
| // for an old extension when uninstalling or changing versions | ||
| const installedExtensions = new Set(await getInstalledExtensions()); | ||
| console.log(`${LOG_PREFIX} Found installed extensions: `, Array.from(installedExtensions)); |
Contributor
There was a problem hiding this comment.
lets output all logs to an output channel https://code.visualstudio.com/api/references/vscode-api#OutputChannel
| export const IMAGE_EXTENSIONS_DIR = "/opt/amazon/sagemaker/sagemaker-code-editor-server-data/extensions"; | ||
| export const LOG_PREFIX = "[sagemaker-extensions-sync]"; | ||
|
|
||
| export class ExtensionInfo { |
Contributor
There was a problem hiding this comment.
nit: this probably fit better in file named "ExtensionInfo"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds an extension that notifies users if the extensions directory is missing pre-packaged extensions from SageMaker Distribution and give them the option to sync them.
Testing
Built conda package locally and tested as a custom image in SageMaker
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.