Updated dialog warning handling for getExpiryTime#31
Open
aws-spenceng wants to merge 2 commits intoaws:mainfrom
Open
Updated dialog warning handling for getExpiryTime#31aws-spenceng wants to merge 2 commits intoaws:mainfrom
aws-spenceng wants to merge 2 commits intoaws:mainfrom
Conversation
Contributor
|
okay I see you added them internally. nevermind |
| showWarningDialog(); | ||
| }, warningTime); | ||
| if (getExpiryTime(sagemakerCookie) !== -1) { | ||
| if (timeToExpiry <= 0) { |
Contributor
There was a problem hiding this comment.
curious, why do you use getExpiryTime() in 74 and timeToExpiry in 75, 77, 84, etc? is there a difference?
Contributor
Author
There was a problem hiding this comment.
getExpiryTime and timeToExpiry refer to different values
getExpiryTime- is the value of the localexpiryTimeset by Code Editor. When the cookie is present, it gives the UNIX time of the expiry time (8 hours ahead of app start up). When no cookie is present, it returns-1timeToExpiry- is the UNIX expiry time - the current time (8 hours). We use this to compare against 15 min to provide the warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Addresses issue where in local environment, a false "Sign In" notification is shown due to the
elsecondition handlingOriginally,
getExpiryTimehas a numeric value <= 0 or-1(the original value passed as null, see:sagemaker-code-editor/patched-vscode/extensions/sagemaker-extension/src/constant.ts
Line 70 in e25a34b
The conditional for the
signInErrortriggered when the value ofgetExpiryTime<=0, which was the case as an emptyexpiryTimecookie still lead toexpiryTimebeing populated as-1.Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.