Open
Conversation
| @@ -65,41 +52,11 @@ Index: sagemaker-code-editor/vscode/src/vs/code/browser/workbench/workbench.ts | |||
| } | |||
|
|
|||
| private startListening(): void { | |||
| @@ -550,17 +551,6 @@ class WorkspaceProvider implements IWork | |||
Contributor
There was a problem hiding this comment.
can you double check that reemoving this entire patch is correct
Contributor
Author
There was a problem hiding this comment.
yes the function is not get deleted in vscode , ref: https://github.com/microsoft/vscode/blob/release/1.93/src/vs/code/browser/workbench/workbench.ts
| @@ -146,20 +103,7 @@ Index: sagemaker-code-editor/vscode/src/vs/server/node/webClientServer.ts | |||
| embedderIdentifier: 'server-distro', | |||
| extensionsGallery: this._webExtensionResourceUrlTemplate && this._productService.extensionsGallery ? { | |||
| ...this._productService.extensionsGallery, | |||
| @@ -340,8 +345,10 @@ export class WebClientServer { | |||
Contributor
There was a problem hiding this comment.
same here, it's removing a lot and not adding anything back
| const workbenchWebConfiguration = { | ||
| remoteAuthority, | ||
| webviewEndpoint: vscodeBase + this._staticRoute + '/out/vs/workbench/contrib/webview/browser/pre', | ||
| serverBasePath: this._basePath, |
Contributor
There was a problem hiding this comment.
this might belong in the base-path.diff
| @@ -164,37 +165,13 @@ Index: sagemaker-code-editor/vscode/product.json | |||
| + }, | |||
| + "linkProtectionTrustedDomains": [ | |||
| + "https://open-vsx.org" | |||
| ] | |||
Contributor
There was a problem hiding this comment.
why is all this being removed?
| @@ -250,27 +250,3 @@ Index: sagemaker-code-editor/vscode/extensions/sagemaker-terminal-crash-mitigati | |||
| +# yarn lockfile v1 | |||
| + | |||
| + | |||
| Index: sagemaker-code-editor/vscode/build/npm/dirs.js | |||
Contributor
There was a problem hiding this comment.
same here, why is all this being removed. we need this
|
@aws-aijiacen or @aws-pangestu will this be continued and merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Update Patched VS Code version to 1.93.0 with patches applied
Update README with detailed release instructions
Testing:
sh ./scripts/install.sh
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.