feat: Change parseCookie command to read from HTTP request header#97
Closed
ahusseinali wants to merge 1 commit intoaws:mainfrom
ahusseinali:modify-parse-cookie
Closed
feat: Change parseCookie command to read from HTTP request header#97ahusseinali wants to merge 1 commit intoaws:mainfrom ahusseinali:modify-parse-cookie
ahusseinali wants to merge 1 commit intoaws:mainfrom
ahusseinali:modify-parse-cookie
Conversation
bhadrip
approved these changes
Dec 19, 2024
bhadrip
left a comment
bhadrip
left a comment
There was a problem hiding this comment.
Looks good !
Do we need any unit test to make sure future upgrades are not breaking this ?
…AccessToken & StudioSessionToken
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Current parseCookie command doesn't parse AccessToken and StudioSession Token as they're marked as HttpOnly cookies. VS Code Extensions (specifically AWS Toolkit & Amazon Q extension) need to be able to read these cookies to auto-login SSO user (using their access token instead of Container credentials).
Description of changes:
Switch parseCookie command to read cookies from a new Http server end point that echos back the cookie credentials to the caller.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.