Fix serverless endpoint configuration field name conversion#308
Open
MarcusKoolaard wants to merge 1 commit intoaws:mainfrom
Open
Fix serverless endpoint configuration field name conversion#308MarcusKoolaard wants to merge 1 commit intoaws:mainfrom
MarcusKoolaard wants to merge 1 commit intoaws:mainfrom
Conversation
Fixes field name conversion bug where acronyms in snake_case were not properly capitalized when converted to PascalCase for AWS API calls: - memory_size_in_mb now converts to MemorySizeInMB (not MemorySizeInMb) - supported_response_mime_types now converts to SupportedResponseMIMETypes (not SupportedResponseMimeTypes) This resolves parameter validation failures when creating serverless endpoint configurations and inference specifications. Also removed duplicate snake_to_pascal function definition.
MarcusKoolaard
had a problem deploying
to
manual-approval
GitHub Actions
Failure
Author
|
@pintaoz-aws are you able to review? |
|
can someone have a look and merge this? This is a clear bug with no workaround and open for 2 month 🥹 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes field name conversion bug where acronyms in snake_case were not properly capitalized when converted to PascalCase for AWS API calls:
This resolves parameter validation failures when creating serverless endpoint configurations and inference specifications.
Also removed duplicate snake_to_pascal function definition.
#225
Test plan
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.