Open
Conversation
Tested by runningn hyp recipe-init and hyp recipe-validate on recipe files
| import os | ||
| import yaml | ||
| from typing import Dict, Any, Optional | ||
| from hyperpod_pytorch_job_template.v1_0.recipes.hf.model import HfRecipeSchema |
Member
There was a problem hiding this comment.
Here we are directly loading from v1_0 but what we need is to use the version aware registry pull up?
is this something we will iterate on based on recent change?
Collaborator
There was a problem hiding this comment.
Good catch. Yes. @zhaoqizqwang pls look at latest changes from Roja : https://github.com/aws/private-sagemaker-hyperpod-cli-staging/pull/154 for handling this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested by runningn hyp recipe-init and hyp recipe-validate on recipe files
PR Approval Steps
For Requester
For Reviewer
For Requestersection to double check each item.