Tweaks prompted by writing the AutoCorrode paper #62
+104
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominic-mulligan-aws
requested changes
Feb 2, 2026
Contributor
dominic-mulligan-aws
left a comment
dominic-mulligan-aws
left a comment
There was a problem hiding this comment.
@lawrencecpaulson a large number of changes in this PR are related to removing braces around the len sort. Can these be reverted? They obscure more meaningful changes. Can you also clarify who Lukas is, mentioned in the comment, and what license the code he has written is submitted under?
|
|
||
| lemma lt_word_to_natI [word_nat_intros]: | ||
| fixes a b :: \<open>'l::{len} word\<close> | ||
| fixes a b :: \<open>'l::len word\<close> |
| using assms by (auto simp add: of_nat_inverse word_of_nat_le intro!: sorted_list_map_mono sorted_upt) | ||
|
|
||
| lemma add_word_lessI: | ||
| fixes a :: "'a::len word" |
Contributor
There was a problem hiding this comment.
Can you consistently use cartouches?
|
|
||
| lemma set_of_wordlist: | ||
| fixes M N :: \<open>nat\<close> | ||
| fixes M N :: \<open>nat\<close> |
Contributor
There was a problem hiding this comment.
Can you maintain the alignment?
| begin | ||
| (*>*) | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Who is Lukas? Do we have any licensing concerns here?
| \<star> (ll_points_to ds next_ref_opt remainder)) | ||
| \<close> | ||
|
|
||
| (*TODO: not used; delete?*) |
Contributor
There was a problem hiding this comment.
If we're not using this we can just delete it.
Contributor
|
Superceded by #78. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are minor changes that should have no observable effect
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.