Extend shallow pattern support and add regression tests #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make pattern translations total and tolerate wrapper forms to avoid Match in the bcase frontend. - Allow nested patterns in constructor args by expanding collection/translation logic in Basic_Case_Expression. - Normalize tuple patterns into Pair/TNil shape in the shallow match frontend. - Improve shallow match arg translation to distinguish bindings vs constructors and handle nested tuple patterns. - Add nested-pattern showcase/regression tests (Option/Result, tuples, wildcards, if-let and let-else forms). Closes awslabs#65. Signed-off-by: Dominic Mulligan <dominic.p.mulligan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the bcase frontend.
logic in Basic_Case_Expression.
and handle nested tuple patterns.
if-let and let-else forms).
Closes #65.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.