Add ability to set mvn repo search URL with a Unique ENV Variable#274
Merged
lucienlu-aws merged 1 commit intoawslabs:masterfrom Apr 22, 2025
ttrankle:feature/add-ability-to-set-mvn-repo
Merged
Add ability to set mvn repo search URL with a Unique ENV Variable#274lucienlu-aws merged 1 commit intoawslabs:masterfrom ttrankle:feature/add-ability-to-set-mvn-repo
lucienlu-aws merged 1 commit intoawslabs:masterfrom
ttrankle:feature/add-ability-to-set-mvn-repo
Conversation
Contributor
Author
|
@ethkatnic @lucienlu-aws Do you know how we can get this PR or a similar one reviewed? Its a super small change but would stabilize builds for many teams. |
lucienlu-aws
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#209
Description of changes:
This PR add the ability to set a unique URL to download the required Jars from. Unlike #216, this adds the ability to set the entire URL while making sure the env name is unique.
This PR is specifically useful for teams that need to use a private Artifactory or hub to download the jars.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.