Open
Conversation
charleswhchan
commented
Aug 5, 2017
charleswhchan
commented
- change self._SLEEP_SECONDS to self._CHECKPOINT_SLEEP_SECONDS to avoid naming conflict with user code that also implements sleep/delay
- move process_record(), should_update_sequence(), and checkpoint() after process_records() so the code is more fluent when read and makes the context clearer
- also added '_' prefix to the aforementioned functions to indicate internal functions
- change self._SLEEP_SECONDS to self._CHECKPOINT_SLEEP_SECONDS to avoid naming conflict with user code that also implements sleep/delay - move process_record(), should_update_sequence(), and checkpoint() after process_records() so the code is more fluent when read and makes the context clearer - also added '_' prefix to the aforementioned functions to indicate internal functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.