Sugerencias de Refactoring

.classpath

@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<classpath>
+	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
+	<classpathentry kind="src" path="src"/>
+	<classpathentry kind="lib" path="libs/mockito-all-1.10.14.jar"/>
+	<classpathentry kind="output" path="bin"/>
+</classpath>

.gitignore

@@ -16,3 +16,4 @@
 
 # virtual machine crash logs, see http://www.java.com/en/download/help/error_hotspot.xml
 hs_err_pid*
+/bin/

.project

@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<projectDescription>
+	<name>CodeSmells</name>
+	<comment></comment>
+	<projects>
+	</projects>
+	<buildSpec>
+		<buildCommand>
+			<name>org.eclipse.jdt.core.javabuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+	</buildSpec>
+	<natures>
+		<nature>org.eclipse.jdt.core.javanature</nature>
+	</natures>
+</projectDescription>

src/com/directi/training/codesmells/duplicatecode/RStatistics.java

@@ -0,0 +1,31 @@
+package com.directi.training.codesmells.duplicatecode;
+
+public class RStatistics {
+
+	 private double getAverage(double[] array) {
+	        double cont = 0;
+	        for (double element : array) {
+	            cont += element;
+	        }
+	        return cont / array.length;
+	 }
+
+	 public double calculateSampleVariance(double[] elements) {
+	        double average = getAverage(elements);
+	        double count = 0.0;
+	        for (double e : elements) {
+	        	count += Math.pow(e - average, 2);
+	        }
+	        return count / (elements.length - 1);
+	 }
+
+	 public double calculateDifferenceOfAverage(double[] array1, double[] array2) {
+	        return Math.abs(getAverage(array1) - getAverage(array2));
+	 }
+
+}
+
+
+
+
+

src/com/directi/training/codesmells/duplicatecode/Statistics.java

@@ -38,4 +38,4 @@ public double calculateSampleVariance(double[] elements)
         return temp / (elements.length - 1);
 
     }
-}
+}

src/com/directi/training/codesmells/featureenvy/Address.java

@@ -1,53 +1,50 @@
 package com.directi.training.codesmells.featureenvy;
 
-public class Address
-{
-
-    private String _addressLine1;
+public class Address {
+	private String _addressLine1;
     private String _addressLine2;
     private String _city;
     private String _state;
     private String _country;
     private String _postalCode;
 
-    public Address(String addressLine1, String addressLine2, String city, String state,
-                   String country, String postalCode)
-    {
-        _addressLine1 = addressLine1;
-        _addressLine2 = addressLine2;
-        _city = city;
-        _state = state;
-        _country = country;
-        _postalCode = postalCode;
-    }
-
-    public String getAddressLine1()
-    {
-        return _addressLine1;
-    }
-
-    public String getAddressLine2()
-    {
-        return _addressLine2;
-    }
-
-    public String getCity()
-    {
-        return _city;
-    }
-
-    public String getState()
-    {
-        return _state;
-    }
-
-    public String getCountry()
-    {
-        return _country;
-    }
-
-    public String getPostalCode()
-    {
-        return _postalCode;
-    }
+	public Address(String addressLine1, String addressLine2, String city, String state, String country,
+			String postalCode) {
+		_addressLine1 = addressLine1;
+		_addressLine2 = addressLine2;
+		_city = city;
+		_state = state;
+		_country = country;
+		_postalCode = postalCode;
+	}
+
+	public String getAddressLine1() {
+		return _addressLine1;
+	}
+
+	public String getAddressLine2() {
+		return _addressLine2;
+	}
+
+
+
+	public String getCity() {
+		return _city;
+	}
+
+	public String getState() {
+		return _state;
+	}
+
+	public String getCountry() {
+		return _country;
+	}
+
+	public String getPostalCode() {
+		return _postalCode;
+	}
+
+
+
+
 }

src/com/directi/training/codesmells/featureenvy/Customer.java

@@ -1,24 +1,17 @@
 package com.directi.training.codesmells.featureenvy;
 
-public class Customer
-{
-    private String _name;
-    private Address _currentAddress;
+public class Customer {
+	private String _name;
+	private Address _currentAddress;
 
-    public Customer(String name, Address address)
-    {
-        _name = name;
-        _currentAddress = address;
-    }
+	public Customer(String name, Address address) {
+		_name = name;
+		_currentAddress = address;
+	}
 
-    public void printAddress()
-    {
-        System.out.println(
-            _currentAddress.getAddressLine1() + "\n" + _currentAddress.getAddressLine2() + "\n" +
-            _currentAddress.getCity() + ", " + _currentAddress.getState() + "\n" +
-            _currentAddress.getPostalCode());
-    }
-
-    //other methods related to customer class.....
+	public void printAddress() {
+		System.out.println(_currentAddress);
+	}
 
 }
+

src/com/directi/training/codesmells/featureenvy/RAddress.java

@@ -0,0 +1,103 @@
+package com.directi.training.codesmells.featureenvy;
+
+public class RAddress {
+
+	private String _addressLine1;
+    private String _addressLine2;
+    private String _city;
+    private String _state;
+    private String _country;
+    private String _postalCode;
+
+	public RAddress(String _addressLine1, String _addressLine2, String _city, String _state, String _country,
+			String _postalCode) {
+		super();
+		this._addressLine1 = _addressLine1;
+		this._addressLine2 = _addressLine2;
+		this._city = _city;
+		this._state = _state;
+		this._country = _country;
+		this._postalCode = _postalCode;
+	}
+
+
+
+	public String get_addressLine1() {
+		return _addressLine1;
+	}
+
+
+
+	public void set_addressLine1(String _addressLine1) {
+		this._addressLine1 = _addressLine1;
+	}
+
+
+
+	public String get_addressLine2() {
+		return _addressLine2;
+	}
+
+
+
+	public void set_addressLine2(String _addressLine2) {
+		this._addressLine2 = _addressLine2;
+	}
+
+
+
+	public String get_city() {
+		return _city;
+	}
+
+
+
+	public void set_city(String _city) {
+		this._city = _city;
+	}
+
+
+
+	public String get_state() {
+		return _state;
+	}
+
+
+
+	public void set_state(String _state) {
+		this._state = _state;
+	}
+
+
+
+	public String get_country() {
+		return _country;
+	}
+
+
+
+	public void set_country(String _country) {
+		this._country = _country;
+	}
+
+
+
+	public String get_postalCode() {
+		return _postalCode;
+	}
+
+
+
+	public void set_postalCode(String _postalCode) {
+		this._postalCode = _postalCode;
+	}
+
+	@Override
+	public String toString() {
+		return "Address [_addressLine1=" + _addressLine1 + ", _addressLine2=" + _addressLine2 + ", _city=" + _city
+				+ ", _state=" + _state + ", _country=" + _country + ", _postalCode=" + _postalCode + "]";
+	}
+
+
+
+}

src/com/directi/training/codesmells/featureenvy/RCustomer.java

@@ -0,0 +1,5 @@
+package com.directi.training.codesmells.featureenvy;
+
+public class RCustomer {
+
+}

src/com/directi/training/codesmells/largeclass/Employee.java

@@ -25,4 +25,7 @@ public String getName()
     {
         return _name;
     }
-}
+}
+
+
+

src/com/directi/training/codesmells/largeclass/InformationEmployee.java

@@ -0,0 +1,24 @@
+package com.directi.training.codesmells.largeclass;
+
+public class InformationEmployee {
+
+	private final String _officeAreaCode;
+    private final String _officeNumber;
+    private final String _officeExtensionNumber;
+
+    public InformationEmployee(String _officeAreaCode, String _officeNumber, String _officeExtensionNumber) {
+		super();
+		this._officeAreaCode = _officeAreaCode;
+		this._officeNumber = _officeNumber;
+		this._officeExtensionNumber = _officeExtensionNumber;
+	}
+
+	@Override
+	public String toString() {
+		return "InformationEmployee [_officeAreaCode=" + _officeAreaCode + ", _officeNumber=" + _officeNumber
+				+ ", _officeExtensionNumber=" + _officeExtensionNumber + "]";
+	}
+
+}
+
+

src/com/directi/training/codesmells/largeclass/REmployee.java

@@ -0,0 +1,24 @@
+package com.directi.training.codesmells.largeclass;
+
+public class REmployee {
+
+	private final String _name;
+	private final InformationEmployee informationEmployee;
+
+	public REmployee(String _name, InformationEmployee informationEmployee) {
+		super();
+		this._name = _name;
+		this.informationEmployee = informationEmployee;
+	}
+
+	public String get_name() {
+		return _name;
+	}
+
+	public InformationEmployee getInformationEmployee() {
+		return informationEmployee;
+	}
+
+
+
+}