Open
Conversation
Closed
Owner
|
Hey @YPCrumble, thanks for working on this! I'm back from the dead and would be happy to get this merged, but it's gonna need a little bit of rework since I've changed up how parsing works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@aykamko this resolves #23 to allow passing the
-gflag. It returns the tagged filename, and then editing that file (e.g., using the aliase1) would take you to the first line of the file in vim.Per your suggestion the changes don't impact any environment variables. using the
--notagflag still returns the untagged filenames without issue.Let me know what you think? It's my first commit to a golang repo so any advice feedback would be welcome.
Thanks again for building this!