Skip to content

Dyn traits, and switched to trim_end_matches #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ivd-git wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Dyn traits, and switched to trim_end_matches #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 42 additions & 42 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/smtp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ impl Connection {
}

/// Handle an incoming connection
pub fn handle(reader: &mut BufRead, writer: &mut Write) -> Result<Connection, Error> {
pub fn handle(reader: &mut dyn BufRead, writer: &mut dyn Write) -> Result<Connection, Error> {
let mut result = Connection::new();

writeln!(writer, "{}", MSG_READY)?;
Expand All @@ -80,7 +80,7 @@ impl Connection {
let mut line = String::new();
reader.read_line(&mut line)?;
// read_line will leave trailing newlines which must be removed
match result.feed_line(line.trim_right_matches(|c: char| c == '\n' || c == '\r')) {
match result.feed_line(line.trim_end_matches(|c: char| c == '\n' || c == '\r')) {
Ok("") => {}
Ok(s) => {
writeln!(writer, "{}", s)?;
Expand Down