Skip to content

Jump by match instead of by search result#17

Merged
aziz merged 7 commits intoaziz:masterfrom
kl0tl:fix/matches-navigation
Jul 1, 2016
Merged

Jump by match instead of by search result#17
aziz merged 7 commits intoaziz:masterfrom
kl0tl:fix/matches-navigation

Conversation

@kl0tl
Copy link
Collaborator

@kl0tl kl0tl commented Jun 27, 2015

This emulates find_prev and find_next but without relying on the Search Panel’s content. Unlike the current behaviour, find_in_files_jump_match will not jump to the first mention of the search result (Y in Searching X file for "Y") neither will it jump to the first match when the last is selected and vice versa like find_prev and find_next do. The latter is already implemented as an option here. I can make only one pull request for both features or wait for this one to be merged first as you prefer.

Fixes #16.

@aziz
Copy link
Owner

aziz commented Jul 11, 2015

Thanks @kl0tl for all these awesome PR. could you merge your cycle feature to this branch so that I can merge them together.
BTW, I can give you push access if you're interested. It seems that you know enough about this package already to take it further.

@kl0tl
Copy link
Collaborator Author

kl0tl commented Jul 11, 2015

Thank you @aziz for this package :)

I’ll merge the cycle option into this PR (better naming than wrap btw, I’ll change it). Should it be True by default or added to the keybindings to preserve the behavior of find_prev and find_next ?

I’ll be very interested in having push access, would be easier to tinker with #12 that way.

@kl0tl kl0tl force-pushed the fix/matches-navigation branch from c6f02b5 to d2f962f Compare July 14, 2015 21:42
@excetara2
Copy link

excetara2 commented May 17, 2016

Was this ever integrated? I was having problems with j and k working so figured this might fix it.

@aziz aziz merged commit 005d34e into aziz:master Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants