feat: Automatically expand properties when adding effects#1485
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b2327ae50
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR adds automatic property panel expansion when adding filter effects, audio effects, or transforms to timeline elements. The implementation attempts to auto-expand newly added items by setting IsExpanded.Value = true on the newly created ViewModel after calling AddItem.
Changes:
- Auto-expand newly added filter effects, audio effects, and transforms
- Access the last item in the ListEditorViewModel's Items collection after adding to the underlying data
- Set IsExpanded to true on the newly added item's ViewModel
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Beutl/ViewModels/Editors/FilterEffectEditorViewModel.cs | Added logic to find and expand the newly added filter effect item |
| src/Beutl/ViewModels/Editors/AudioEffectEditorViewModel.cs | Added logic to find and expand the newly added audio effect item |
| src/Beutl/ViewModels/Editors/TransformEditorViewModel.cs | Added logic to find and expand the newly added transform item |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
When a filter effect, audio effect, or transform is added via AddItem, automatically expand the newly added item's properties panel so users don't have to manually click to expand it.
yuto-trd
force-pushed
the
feat/auto-expand-added-effect
branch
from
7b2327a to
57b2f1f
Compare
|
No TODO comments were found. |
Minimum allowed line rate is |
yuto-trd
changed the title
1 participant
Description
When adding filter effects, audio effects, or transforms, the property panel of the newly added item is now automatically expanded.
This is achieved by setting
IsExpanded.Value = trueafterAddItemexecution, eliminating the need for manual expansion by the user. Existing items are unaffected (applies only to newly added items).Breaking changes
None
Fixed issues
None