This repository was archived by the owner on Mar 9, 2025. It is now read-only.
modified 'start' script so changes to files in 'lib' trigger restart#46
Open
OmarHussainX wants to merge 1 commit intobabel:masterfrom
Open
modified 'start' script so changes to files in 'lib' trigger restart#46OmarHussainX wants to merge 1 commit intobabel:masterfrom
OmarHussainX wants to merge 1 commit intobabel:masterfrom
Conversation
…nspiling to 'dist' and server restart
|
@OmarHussainX I think that you could use the proposal from this answer for the issue: #38 (comment)
And then you should update READ.md https://github.com/babel/example-node-server#example-node-server-w-babel Watching file changes with nodemon could be move after Getting ready for production use section. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you for this example.
I'm assuming the intended behaviour for the
npm startscript is that changes tolib/index.jswould show (after an automatic server restart) in the server running athttp://127.0.0.1:1337/That's the behaviour I expect, and I believe this is what was intended since the README states:
However the provided
npm startscript does not do this - changes tolib/index.jsare detected, and trigger a server restart, but no transpilation is done, sodist/index.jsis not updated and thus changes inlibdo not appear in the server.I've revised the
npm startscript so that:nodemonexplicitly watcheslibfor changes, when a change occurslibis transpiled todist, and then the server is restarted.