refactor: extract shared route handlers and modularize plan server#214
Merged
backnotprop merged 2 commits intomainfrom Mar 4, 2026
Merged
refactor: extract shared route handlers and modularize plan server#214backnotprop merged 2 commits intomainfrom
backnotprop merged 2 commits intomainfrom
Conversation
Pull duplicated /api/image, /api/upload, /api/agents handlers and handleServerReady into shared-handlers.ts. Move /api/doc and Obsidian reference endpoints into reference-handlers.ts. Eliminates ~120 lines of verbatim duplication across index.ts, review.ts, and annotate.ts. Closes #210 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
Export OpencodeClient interface from shared-handlers.ts and import it in index.ts and review.ts instead of redefining inline. Also corrects the module doc comment about /api/agents usage scope. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/image,/api/upload,/api/agentshandlers intopackages/server/shared-handlers.ts/api/docand Obsidian reference endpoints intopackages/server/reference-handlers.tshandleServerReadyfunctions into one shared exportindex.tsdrops from 706 → 454 lines,review.ts323 → 259,annotate.ts258 → 207Closes #210
Test plan
bun run build:hooksucceeds🤖 Generated with Claude Code