Initial work to do reliable backup of SSM parameters#1
Initial work to do reliable backup of SSM parameters#1michael-paddle wants to merge 14 commits intoreviewedfrom
Conversation
michael-paddle
changed the title
| @@ -0,0 +1,41 @@ | |||
| AWS_ACCOUNT_NAME ?= michael | |||
There was a problem hiding this comment.
Should we remove all AWS defaults ?
There was a problem hiding this comment.
it's there as a reminder to set up credentials which make it difficult to accidentally do things on production. Will become clear when I add CI.
| AWS_ACCOUNT_NAME ?= michael | ||
| AWS_DEFAULT_REGION ?= eu-west-1 | ||
| PYTHON ?= python3 | ||
| BEHAVE ?= behave |
There was a problem hiding this comment.
as above - will commit to clear this up soon
| The CLI tool provides a simple interface to dump or restore the full | ||
| set of SSM parameters. | ||
|
|
||
| 1) set up the appropriate environment including AWS variables |
There was a problem hiding this comment.
Can we be more specific ?
For example for DR, I would like just to copy/past steps.
| # full pytest tests so that failures are detected early where possible. | ||
| test: develop pytest-mocked behave pytest | ||
|
|
||
| behave: |
There was a problem hiding this comment.
Can we add the comments for the each command (ideally on the same line as the command name) - see the comment about the help command below.
There was a problem hiding this comment.
@michael-paddle could you please add this? It is not super clear what each command does
| pytest: | ||
| pytest | ||
|
|
||
| wip: develop |
There was a problem hiding this comment.
work in progress - standard behave / BDD development acronym
There was a problem hiding this comment.
I think what Johan means is it is not clear what this command does.
|
|
||
| # develop is needed to install scripts that are called during testing | ||
| develop: .develop.makestamp | ||
|
|
There was a problem hiding this comment.
If needed, can we add setup command ?
There was a problem hiding this comment.
I'm not sure if it's useful; setup alone doesn't get you to a state where the test cases can pass. I'd rather not get that as something people expect to run until the time that we have it as a useful thing to do.
3 participants
Initial PR for all work needed to get MVP reliable backup of SSM parameters.