Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't as big a deal as the race condition fix, but it would be nice to have. At the lowest (numerically, highest) priority the present system can barely distinguish at the one-second level. By scaling the time stamp appropriately, the resolution can be improved considerably to the point where deltas smaller than 1ms can be distinguished.
This primarily matters when a process is spawning multiple jobs at the same priority in quick succession; if jobs are spawned more rapidly that the resolution, they are effectively unordered in the queue. While this is a relatively easy situation to construct with the unpatched version, it is significantly harder with the patched code as the resolution for reasonable priorities is (on all systems this code has been tested on) on the order of the time required to queue a job.