Assignment 2

[barunip]

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Update code to summarize patient data

What did you learn from the changes you have made?

Variable/function names have different meaning depending on the library you use

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

None

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

N/A

How were these changes tested?

On sample patient file 0

A reference to a related issue in your repository (if applicable)

Checklist

• [y ] I can confirm that my changes are working as intended

[efantinatti]

Hi @barunip Q1 is OK. Q2 you may consider running max and mean. Q3 you may also consider testing all the files and see which of them you get the True values.

Best,
E. Fantinatti

[barunip]

HI @efantinatti

My apologies did I miss those instruction or are these just suggestions? For the testing of all files do you need to see a log of each file's results?

Also for your comment 'still in progress' - is there an additional step I'm supposed to take?

Thank you!

[efantinatti]

Hi @barunip yeah, seeing a log of these outputs helps marking your assignment.

Best
@efantinatti

[barunip]

@efantinatti can you please advise on the other questions i asked above? I do not see the requirement in the assignment - thank you.

[efantinatti]

Hi @barunip your Q2 you are not printing the whole scenario, with the options testing the whole solution. The same applies to Q3, consider scanning the files to find the True value in them.

Best
@efantinatti

[barunip]

Hi @efantinatti I have updated it accordingly. Thank you.

[efantinatti]

Hi @barunip Q3 is OK but Q2 is also not printing the outputs, just its lengths.

Best
@efantinatti

[barunip]

@efantinatti got it! (i think). File has been updated.

[efantinatti]

Hi @barunip look great now. You may merge it to main.

Best
@efantinatti