-
Notifications
You must be signed in to change notification settings - Fork 174
feat(CHAIN-3293) Migrate Multiproof Contracts to base/contracts #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jjtny1
merged 120 commits into
main
from
joby.thundil/CHAIN-3293-migrate-multiproof-contracts-to-basecontracts
Mar 6, 2026
Merged
Changes from all commits
Commits
Show all changes
120 commits
Select commit
Hold shift + click to select a range
5041935
initial commit
roger-bai-coinbase bd550fd
Refactor tests and simplify verifier
roger-bai-coinbase e1a7654
Refactor proof verification methods to consolidate TEE and ZK proof h…
roger-bai-coinbase 2ea6dff
refactor tests and errors
roger-bai-coinbase 70864f8
Prevent proofs from extending resolution time
roger-bai-coinbase 2ef75e4
ZK proof allows game creator to immediately reclaim bond
roger-bai-coinbase 7e70a75
Additional tests
roger-bai-coinbase ab2e400
Refactor test cases to standardize warp duration and improve naming c…
roger-bai-coinbase aa2518d
Add validation to ensure parent game has a proof before creating a ch…
roger-bai-coinbase 1613646
Use calldata and remove unused variable
roger-bai-coinbase 5ba6ed7
Make internal verify functions consistent
roger-bai-coinbase ab2d01b
fix: can claim bond after nullifying a challenge
roger-bai-coinbase 8e38be6
prevent challenges if parent or game itself is invalid
roger-bai-coinbase 3a2b31c
Enhance AggregateVerifier to include hashes for TEE and ZK images, an…
roger-bai-coinbase 0a053f1
Add ReentrancyGuard to AggregateVerifier and protect claimCredit func…
roger-bai-coinbase 308f591
Add constant for initialize calldata size in AggregateVerifier and up…
roger-bai-coinbase 9585f67
Add test to validate failure on invalid calldata size in AggregateVer…
roger-bai-coinbase 45c47f6
Refactor l2BlockNumber function to l2SequenceNumber in AggregateVerif…
roger-bai-coinbase 5cfe30b
Refactor visibility of state variables in AggregateVerifier from inte…
roger-bai-coinbase b2dd1ff
Moved wasRespectedGameTypeWhenCreated for storage optimization
roger-bai-coinbase f0d3f54
Remove underscores from constructor variables
roger-bai-coinbase 5fcecd5
IDIsputeGame compliance
roger-bai-coinbase ba44e13
Remove implicit returns
roger-bai-coinbase 54c4192
Add CreditClaimed event and update claimCredit logic in AggregateVeri…
roger-bai-coinbase 49e2eea
Rename getParentGameStatus to _getParentGameStatus in AggregateVerifi…
roger-bai-coinbase 2b3238d
Refactor return logic in getParentGameStatus to improve clarity by co…
roger-bai-coinbase 8d47e48
solidity style guide
roger-bai-coinbase abe2710
forge fmt
roger-bai-coinbase c200cb7
Fix tests
roger-bai-coinbase 3fbec56
remove unused imports
roger-bai-coinbase 40b8bff
Named imports, reorganized imports, defined errors directly
roger-bai-coinbase 59f58be
linter
roger-bai-coinbase 79fbe48
Add underscores to deal with compiler warnings
roger-bai-coinbase 7991678
Refactor and have consistent comments
roger-bai-coinbase b188c31
Update verifier interface to include image ID
roger-bai-coinbase e0dc966
Added feature where a proof is required for initialization
roger-bai-coinbase 52d9845
Added feature where a proof is required for initialization
roger-bai-coinbase f099f9e
Add back in IDisputeGame inheritance
roger-bai-coinbase e4e32f7
forge fmt
roger-bai-coinbase 6e1ed51
refactor proof format
roger-bai-coinbase 3d1f480
game type validation on challenging game
roger-bai-coinbase fd2b88e
Add delayedWETH
roger-bai-coinbase faebf6e
forge fmt
roger-bai-coinbase 9f4a3d9
Check challenging game validity when claiming credit
roger-bai-coinbase e9fa5a8
Add TEEVerifier and SystemConfigGlobal contracts and update Aggregate…
leopoldjoy d80610f
Merge branch 'main' of github.com:base/multiproof-dispute-game
leopoldjoy 307b6fc
fix(TEEVerifier): use correct EIP-2935 address and raw calldata for b…
leopoldjoy 98693e5
Refactor TEE contracts and deployment script based on PR review feedback
leopoldjoy b9e101d
Refactor TEE contracts and deployment script based on PR review feedback
leopoldjoy 9ff1818
Remove underscore-prefixed parameters from mock contracts per style g…
leopoldjoy f57741c
Add comprehensive tests for TEEVerifier, SystemConfigGlobal, and DevS…
leopoldjoy 01cd442
Update teeProposer to match proposer address
leopoldjoy db1107e
correct teeImageHash in Sepolia deploy config
leopoldjoy e0a9a4b
Merge pull request #1 from base/teeverifier-and-2e2-integration
leopoldjoy 9e2690c
Merge pull request #1 from base/teeverifier-and-2e2-integration
leopoldjoy 26eac98
Moving TEE proposer to TEEVerifier
roger-bai-coinbase b3e4392
fix TEE comment
roger-bai-coinbase e223802
Merge pull request #2 from base/move-tee-proposer-to-tee-verifier
roger-bai-coinbase c192c9b
feat: intermediate roots for nullification
roger-bai-coinbase f0b333f
move L1 origin hash check from TEEVerifier to AggregateVerifier
roger-bai-coinbase c7b1d81
fix tests
roger-bai-coinbase b38214b
forge fmt
roger-bai-coinbase f82f983
feat: split deploy configs and scripts into no-nitro and with-nitro v…
leopoldjoy 8201c04
Merge branch 'main' into feat/split-deploy-configs-and-scripts
leopoldjoy 1801c49
refactor _verifyProof
roger-bai-coinbase 1c4e3fc
Merge pull request #3 from base/intermediate-roots
roger-bai-coinbase 85918ee
added block interval tests and cleaned up some errors
roger-bai-coinbase d9732f3
forge fmt
roger-bai-coinbase 6119424
verify proof earlier during initialize
roger-bai-coinbase db1268c
revert last commit
roger-bai-coinbase 0633e55
refactor initialize
roger-bai-coinbase d3a3bc3
Merge branch 'main' into feat/split-deploy-configs-and-scripts
leopoldjoy 50c088c
refactor
roger-bai-coinbase f59abd6
Merge branch 'simplify-storage-and-refactor' into feat/split-deploy-c…
leopoldjoy cf84877
Merge pull request #5 from base/simplify-storage-and-refactor
roger-bai-coinbase ccac6c3
fix: register TEE proposer during deployment and add intermediateBloc…
leopoldjoy d0c40f0
Merge pull request #4 from base/feat/split-deploy-configs-and-scripts
leopoldjoy 6164a13
use l1head for proofs after initialization
roger-bai-coinbase fd779bc
forge fmt
roger-bai-coinbase 780715d
Fix comments from PR feedback
roger-bai-coinbase 2daabba
Merge pull request #6 from base/use-l1head-after-init
roger-bai-coinbase c2e9154
Merge branch 'main' into joby.thundil/CHAIN-3293-migrate-multiproof-c…
jjtny1 935b7eb
step 1 fix dependencies and op commit
jjtny1 b0726ae
Merge branch 'main' into joby.thundil/CHAIN-3293-migrate-multiproof-c…
jjtny1 920d6e4
make multiproof compatible with base contracts
jjtny1 351a9ba
fix imports in scripts
jjtny1 48c06f9
fix mocks
jjtny1 e986e12
format and seperate out multiproof tests
jjtny1 c0ee7ac
add tests to just and gen semver
jjtny1 7d94460
fix tests
jjtny1 d416a43
rm unecessary op commit
jjtny1 cb97431
apply optimism patch for multiproof
jjtny1 cae85a8
move multiproof tests
jjtny1 cb82112
move files and delete multiproof test usage and profile
jjtny1 ccf3601
remove remappings of nitro and op enclave
jjtny1 1b4343e
undo multiproof changes and solady import change
jjtny1 babc5ad
support AggregateVerifier in initalizer test
jjtny1 7b90711
fix import path
jjtny1 76335ba
semver
jjtny1 1e6412c
semver
jjtny1 5d90e6e
semver
jjtny1 4fd964b
deterministic semverlock
jjtny1 928cfe0
add comment
jjtny1 ee8c3b9
refactor multiproof patch changes. fix typo
jjtny1 3c6111b
semver
jjtny1 e7abb04
fmt
jjtny1 14ed45f
semver
jjtny1 9323dfd
fix tests
jjtny1 3a65398
fix tests where bytecodes size was different
jjtny1 b1dc695
fmt
jjtny1 11a0d84
semver
jjtny1 3953c94
semver
jjtny1 13610a9
semver
jjtny1 c956def
make aggregateverifies excluded like faultdispute game. fix systemcon…
jjtny1 a0f0b14
fmt
jjtny1 6b31f9d
fix tests
jjtny1 5cdba94
semver
jjtny1 8e00905
rm just test-multiproof
jjtny1 3e6f2e7
Replace onchain Nitro cert verification with Automata ZK verifier (#197)
leopoldjoy 320d989
pr feedback: delete unecessary snapshots
jjtny1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,5 +44,8 @@ deploy-config/getting-started.json | |
| # IDE | ||
| /.idea/ | ||
|
|
||
| # Foundry | ||
| foundry.lock | ||
|
|
||
| # OS | ||
| .DS_Store | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {"SystemConfigGlobal":"0xf8293c0f3a36A746B559a1a51870339B20F60945","TEEVerifier":"0x82453dA61B397EE366fB2129502de9c216480aB6","DisputeGameFactory":"0xfEa8Cb315F75d838b6c76ae336a9255f81df0D50","AnchorStateRegistry":"0x556BD554854504BE2F2023F6531D25eF6f6Fe77D","DelayedWETH":"0xb1FB7f05711d2270cD658448562A29E8c5C95E9E","AggregateVerifier":"0xeeF18F1640fa79f919799B5D629908909e715f97"} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| // SPDX-License-Identifier: MIT | ||
| pragma solidity 0.8.15; | ||
|
|
||
| interface IVerifier { | ||
| function verify(bytes calldata proofBytes, bytes32 imageId, bytes32 journal) external view returns (bool); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.