Skip to content

Fix regression regarding installing repos with custom tag #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juanibiapina merged 1 commit into from
Nov 18, 2025
Merged

Fix regression regarding installing repos with custom tag #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions libexec/basher-install
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ fi

if [[ "$package" = */*@* ]]; then
IFS=@ read -r package ref <<< "$package"
if [ "$custom_folder" = "false" ]; then
Copy link

@joseph-galindo joseph-galindo Nov 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L38 nit

"argunment" -> "argument"

Not really related to this PR, I noticed it and wanted to at least write it down

folder="$package"
fi
Comment on lines +64 to +66
Copy link

@joseph-galindo joseph-galindo Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay I had it backwards, so the regression was related to adding support for the new custom folder arg. Which explains why I couldn't see it on really old basher releases (they didn't have the custom folder arg yet).

Thanks for looking into this, this lgtm.

else
ref=""
fi
Expand Down
4 changes: 4 additions & 0 deletions tests/basher-install.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ basher-_link-completions username/package"
run basher-install username/package@v1.2.3

assert_line "basher-_clone false github.com username/package v1.2.3"
assert_line "basher-_deps username/package"
assert_line "basher-_link-bins username/package"
Copy link

@joseph-galindo joseph-galindo Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

assert_line "basher-_link-man username/package"
assert_line "basher-_link-completions username/package"
}

@test "empty version is ignored" {
Expand Down