Skip to content

Conversation

@ChristianStadelmann
Copy link

Prior to this change, any line ending with [punctuation + '...'], for
example ||..., would cause the tokenizer to fail.

Fixes #9

Prior to this change, any line ending with `[punctuation + '...']`, for
example `||...`, would cause the tokenizer to fail.

Fixes bastibe#9
@ChristianStadelmann
Copy link
Author

This is an alternative to #12.

@ChristianStadelmann
Copy link
Author

I know that you don't like the startsWith, although I don't see a simple alternative here because it operates on a cell array of chars here. Do you know any alternative to a second level loop when using the startsWith?

@HaHeho
Copy link

HaHeho commented Jan 20, 2021

I know that you don't like the startsWith, although I don't see a simple alternative here because it operates on a cell array of chars here. Do you know any alternative to a second level loop when using the startsWith?

Don't get me wrong, I very much endorse startsWith(). But Matlab is kind of crazy to introduce that function just in 2016. ;)

Either way, we could also write a unit test case to cover the documented bug and it's fix. Never done that in Matlab and I suppose only very few cases are only implemented there so far? Therefore, I don' know if that is really required.

I suppose it is on @bastibe to decide if and when #12 or #13 gets accepted?!

@bastibe
Copy link
Owner

bastibe commented Jan 20, 2021

I think I generally prefer #12, as I find it a bit easier to follow. However, if you feel #13 is actually a better implementation, I'd go with your suggestions. Honestly, it has been a long while since I last worked with this code, and Matlab in general.

And any improvement of the unit tests would be greatly appreciated, of course!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

&&... makes check throw an error

3 participants