ci: support external fork repositories in reusable workflow#91
Merged
Conversation
Add batfish_repository input to allow callers to specify which repository contains the batfish code to checkout. This enables lab validation for PRs from external contributors, whose branches exist in their forks rather than batfish/batfish. ---- Prompt: ``` Lab validation doesn't work for PRs from external contributors. Now it's failing on: https://github.com/batfish/batfish/actions/runs/21613339182/job/62286746884?pr=9757 /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --depth=1 origin +refs/heads/bgp-confederation-fix*:refs/remotes/origin/bgp-confederation-fix* +refs/tags/bgp-confederation-fix*:refs/tags/bgp-confederation-fix* The process '/usr/bin/git' failed with exit code 1 ``` commit-id:514bf778
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=======================================
Coverage 83.57% 83.57%
=======================================
Files 86 86
Lines 3902 3902
=======================================
Hits 3261 3261
Misses 641 641
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add batfish_repository input to allow callers to specify which
repository contains the batfish code to checkout. This enables
lab validation for PRs from external contributors, whose branches
exist in their forks rather than batfish/batfish.
Prompt: