upgrade poetry2.0 & apply pep621#545
Conversation
till-m
left a comment
till-m
left a comment
There was a problem hiding this comment.
LGTM, generally speaking. Will merge soon.
It seems a bit weird to install uv, to then install poetry later. Using just uv would be nice in the future, but I'm a bit worried about breaking the publishing workflow. Something to keep in mind for the future.
I prefer uv to poetry, so I agree with the later change to uv. But I also agree with the concerns you mentioned. PS1. PS2. |
In that case I will wait with merging this :) |
i fixed it |
|
Thanks for the contribution :) |
* chore: upgrade poetry2.0 & apply pep621 * fix: replace poetry action(not support 2.0) * fix: exclude one matrix * chore: split numpy deps * fix: numpy constraints * fix: install root * chore: use install-poetry
* Add functionality to save and load state of the BayesianOptimization * Update basic-tour with new save and load functionality * move load stateful path to optional argument in class instantiation * add test for string params, update tests with new load functionality * updated basic tour with updated paths * add the random state to the set of things to list of saved items * move state loading to separate function, add functionality for saving acquisition function state * use new loading schema * update tests, add integration tests for saving and loading acquisition functions * undo abstractmethod implementation for get and set state saving functionality * reorganize state saving and loading for consistency * move integration tests into acquisition * remove unndecessary test, add tests for domain reduction and custom parameters * make test more comprehensive * add test logs * sync execution counts from basic tour * linting, whitespace removal, import structuring * ruff fix for string literal in error message * fix ruff complaints * make all side param comparisons almost equal to account for slight numpy differences * reformat array comparison check * upgrade poetry2.0 & apply pep621 (#545) * chore: upgrade poetry2.0 & apply pep621 * fix: replace poetry action(not support 2.0) * fix: exclude one matrix * chore: split numpy deps * fix: numpy constraints * fix: install root * chore: use install-poetry * Fix coverage report (#552) * remove unnecessary files, have acquisition baseclass functions raise errors * remove duplicate acquisition functions random state * ruff format * add type hints for base acquisition get/set functions * remove noreturn * remove former saving functionality from notebooks * increase legibility of custom acquisition example * explicitly stating the optionality of the saving and loading in custom acq functions --------- Co-authored-by: phi-friday <phi.friday@gmail.com> Co-authored-by: till-m <36440677+till-m@users.noreply.github.com>
2 participants
What's different in poetry2.0: Announcing Poetry 2.0.0
Since poetry2.0 now supports pep621, I was able to modify pyproject.toml to conform to the standard spec.
(I kept the modifications to a minimum).
(Since install-poetry doesn't support poetry2.0, I've changed how to install poetry from github action. snok/install-poetry#164)
However, it does not yet support pep735 (dependency groups), so the proprietary specification
tool.poetry.groupis retained.However, this too will be fixed in the future. python-poetry/poetry#9751
If we use poetry in the future, it seems like a good idea to upgrade poetry to 2.0 if possible, as all improvements will only be for 2.0 or later.