Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #552 +/- ##
==========================================
- Coverage 96.19% 96.04% -0.15%
==========================================
Files 10 12 +2
Lines 867 1139 +272
==========================================
+ Hits 834 1094 +260
- Misses 33 45 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closed
adrianmolzon
pushed a commit
to adrianmolzon/BayesianOptimization
that referenced
this pull request
Mar 9, 2025
till-m
added a commit
that referenced
this pull request
Mar 17, 2025
* Add functionality to save and load state of the BayesianOptimization * Update basic-tour with new save and load functionality * move load stateful path to optional argument in class instantiation * add test for string params, update tests with new load functionality * updated basic tour with updated paths * add the random state to the set of things to list of saved items * move state loading to separate function, add functionality for saving acquisition function state * use new loading schema * update tests, add integration tests for saving and loading acquisition functions * undo abstractmethod implementation for get and set state saving functionality * reorganize state saving and loading for consistency * move integration tests into acquisition * remove unndecessary test, add tests for domain reduction and custom parameters * make test more comprehensive * add test logs * sync execution counts from basic tour * linting, whitespace removal, import structuring * ruff fix for string literal in error message * fix ruff complaints * make all side param comparisons almost equal to account for slight numpy differences * reformat array comparison check * upgrade poetry2.0 & apply pep621 (#545) * chore: upgrade poetry2.0 & apply pep621 * fix: replace poetry action(not support 2.0) * fix: exclude one matrix * chore: split numpy deps * fix: numpy constraints * fix: install root * chore: use install-poetry * Fix coverage report (#552) * remove unnecessary files, have acquisition baseclass functions raise errors * remove duplicate acquisition functions random state * ruff format * add type hints for base acquisition get/set functions * remove noreturn * remove former saving functionality from notebooks * increase legibility of custom acquisition example * explicitly stating the optionality of the saving and loading in custom acq functions --------- Co-authored-by: phi-friday <phi.friday@gmail.com> Co-authored-by: till-m <36440677+till-m@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
technically a draft PR, but I need the CI to run to see if it works now.